-
Notifications
You must be signed in to change notification settings - Fork 355
Fix nightly CI #4386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly CI #4386
Conversation
|
Do we know why exactly this warning is triggered? I remember debugging the same not too long ago, but I don't remember what came of it :/ |
bef6924 to
5aa44a9
Compare
|
Hmm, I'm not sure this is the real fix. Isn't this likely related to the fact that when building no_std the compiler/cargo won't emit the check |
|
I spent some time analyzing this and here is the summary: 1.) This is on by default 2.) Related from https://doc.rust-lang.org/rustc/check-cfg.html:
So, if I'm not missing something crucial here, I don't know how to deal with the errors besides what this PR does (adding EDIT: when it started to happen: |
5aa44a9 to
88db665
Compare
| ignored = ["md-5", "esp-hal-procmacros"] | ||
|
|
||
| [lints.rust] | ||
| # Starting with 1.85.0, the test cfg is considered to be a "userspace" config despite being also set by rustc and should be managed by the build system itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit wordy but probably fine
bjoernQ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this won't get any better the longer we wait - we should investigate this further and eventually come back to the unexpeced-cfg "workaround" but it won't harm to have it
bugadani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why this started happening now (the relevant changes were introduced in ~February), and why only on Linux - I can't reproduce any of the warnings (except for the actualy clippy lint) on Windows. Having this workaround makes me sad, and we should revisit in the future in case it can be removed.
Gets rid of
closes #4384