-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add Seeed Studio XIAO ESP32-S3 PoE to Bluetooth Proxy device list #5540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughAdds a Seeed Studio XIAO W5500 PoE option to the Bluetooth proxy device selection in the project template and includes a hidden info block with device description and a purchase link. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📓 Common learnings🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
static/projects/bluetooth-proxy/seeed-esp32-poe.pngis excluded by!**/*.png
📒 Files selected for processing (1)
themes/esphome-theme/layouts/_default/projects.html(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
- Do not generate or add any sequence diagrams
Files:
themes/esphome-theme/layouts/_default/projects.html
🔇 Additional comments (2)
themes/esphome-theme/layouts/_default/projects.html (2)
517-530: Device information block looks good.The info block is correctly structured with matching class names, descriptive heading and purchase links. The description appropriately mentions WiFi being disabled after installation, consistent with similar PoE devices.
351-362: Image file verified—no issues found.The image file exists at
static/projects/bluetooth-proxy/seeed-esp32-poe.png, which correctly corresponds to the path/projects/bluetooth-proxy/seeed-esp32-poe.pngreferenced in the src attribute.
| <label> | ||
| <input | ||
| type="radio" | ||
| name="bluetooth-device" | ||
| class="device-option" | ||
| value="seeed-esp32-poe" | ||
| /> | ||
| <img | ||
| src="/projects/bluetooth-proxy/seeed-esp32-poe.png" | ||
| alt="Seeed Studio XIAO W5500 PoE" | ||
| /> | ||
| </label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add custom manifest URL attribute for seeed-esp32-poe device.
According to the PR objectives, this device uses a custom firmware manifest at https://bohrium332.github.io/bluetooth-proxy/seeed-esp32-poe/manifest.json. However, the radio button lacks a data-manifest-root attribute, so the installer will incorrectly use the default manifest root (https://firmware.esphome.io/bluetooth-proxy), resulting in the wrong manifest URL.
Apply this diff to add the custom manifest root:
<label>
<input
type="radio"
name="bluetooth-device"
class="device-option"
value="seeed-esp32-poe"
+ data-manifest-root="https://bohrium332.github.io/bluetooth-proxy"
/>
<img
src="/projects/bluetooth-proxy/seeed-esp32-poe.png"
alt="Seeed Studio XIAO W5500 PoE"
/>
</label>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <label> | |
| <input | |
| type="radio" | |
| name="bluetooth-device" | |
| class="device-option" | |
| value="seeed-esp32-poe" | |
| /> | |
| <img | |
| src="/projects/bluetooth-proxy/seeed-esp32-poe.png" | |
| alt="Seeed Studio XIAO W5500 PoE" | |
| /> | |
| </label> | |
| <label> | |
| <input | |
| type="radio" | |
| name="bluetooth-device" | |
| class="device-option" | |
| value="seeed-esp32-poe" | |
| data-manifest-root="https://bohrium332.github.io/bluetooth-proxy" | |
| /> | |
| <img | |
| src="/projects/bluetooth-proxy/seeed-esp32-poe.png" | |
| alt="Seeed Studio XIAO W5500 PoE" | |
| /> | |
| </label> |
🤖 Prompt for AI Agents
In themes/esphome-theme/layouts/_default/projects.html around lines 351 to 362,
the radio input for the seeed-esp32-poe device is missing the data-manifest-root
attribute so the installer will use the default manifest root; add
data-manifest-root="https://bohrium332.github.io/bluetooth-proxy/seeed-esp32-poe"
to the <input> element (preserving existing attributes) so the installer
resolves the manifest to the correct custom URL.
Description:
Add support for Seeed Studio XIAO ESP32-S3 PoE board in Bluetooth Proxy and Web Installer.
This PR:
seeed-esp32-poeto the Bluetooth Proxy device list in the web installerhttps://bohrium332.github.io/bluetooth-proxy/seeed-esp32-poe/manifest.jsonRelated issue (if applicable): N/A
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook.New Component Images
If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.
To generate a component image:
Comment on this pull request with the following command, replacing
COMPONENT_NAMEwith your component name in UPPER_CASE format with underscores (e.g.,BME280,SHT3X,DALLAS_TEMP):The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.
Extract the SVG file and place it in the
images/folder of this repository.Use the image in your component's index table entry in
/components/index.rst.Example: For a component called "DHT22 Temperature Sensor", use: