Skip to content

Conversation

@hfudev
Copy link
Member

@hfudev hfudev commented Aug 5, 2025

The current esptool.main(...) call causes the Python process to exit immediately.

This PR bypassed the exitcode 0 to allow the Python code to continue running.

(blocks espressif/pytest-embedded#362)

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello hfudev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against d8ae230

@dobairoland dobairoland requested a review from radimkarnis August 5, 2025 13:45
Copy link
Collaborator

@peterdragun peterdragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but we should also do the same thing for espefuse and espsecure.

@hfudev hfudev force-pushed the fix/program-call-omit-exit-0 branch from b965a53 to d8ae230 Compare August 5, 2025 14:08
@hfudev hfudev requested a review from peterdragun August 5, 2025 14:09
@hfudev
Copy link
Member Author

hfudev commented Aug 5, 2025

Thank you. updated. PTAL again.

Copy link
Collaborator

@peterdragun peterdragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the update.

@dobairoland
Copy link
Collaborator

@hfudev Thank you for this PR and looking into espressif/pytest-embedded#362. Will it be enough for you if we create a dev release with this patch, i.e. 5.1.dev1?

@dobairoland
Copy link
Collaborator

@peterdragun Could you please cherry-pick this into our internal repo?

Copy link
Member

@radimkarnis radimkarnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@hfudev
Copy link
Member Author

hfudev commented Aug 6, 2025

@hfudev Thank you for this PR and looking into espressif/pytest-embedded#362. Will it be enough for you if we create a dev release with this patch, i.e. 5.1.dev1?

Hi @roland can we release a 5.0.3 version? I think it's more like a bugfix instead of a feature.

@dobairoland
Copy link
Collaborator

@hfudev Unfortunately, we already merged several features and the next release from the v5.* line will be 5.1.

@espressif-bot espressif-bot merged commit d8ae230 into master Aug 6, 2025
27 checks passed
@dobairoland dobairoland deleted the fix/program-call-omit-exit-0 branch August 6, 2025 08:39
@dobairoland
Copy link
Collaborator

@hfudev This fix is available in https://pypi.org/project/esptool/5.1.dev1/. Thanks!

@hfudev
Copy link
Member Author

hfudev commented Aug 6, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants