-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: stop exit 0 when being called programmatically #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello hfudev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
peterdragun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but we should also do the same thing for espefuse and espsecure.
b965a53 to
d8ae230
Compare
|
Thank you. updated. PTAL again. |
peterdragun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the update.
|
@hfudev Thank you for this PR and looking into espressif/pytest-embedded#362. Will it be enough for you if we create a dev release with this patch, i.e. 5.1.dev1? |
|
@peterdragun Could you please cherry-pick this into our internal repo? |
radimkarnis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Hi @roland can we release a 5.0.3 version? I think it's more like a bugfix instead of a feature. |
|
@hfudev Unfortunately, we already merged several features and the next release from the v5.* line will be 5.1. |
|
@hfudev This fix is available in https://pypi.org/project/esptool/5.1.dev1/. Thanks! |
|
Thank you! |
The current
esptool.main(...)call causes the Python process to exit immediately.This PR bypassed the exitcode 0 to allow the Python code to continue running.
(blocks espressif/pytest-embedded#362)