Add new fun facts to Fact list #3905

RKBoss6 · 2025-06-26T01:23:37Z

Added many more fun facts, removed redundant ones. eg. (Koalas are native to australia, Koalas are only found in australia)

Removed duplicate facts and added new interesting facts to the list.

gfwilliams · 2025-09-02T10:40:01Z

Looks great to me, thanks!

Just checking - this is tested and works?

RKBoss6 · 2025-09-02T15:04:02Z

I'm actually not sure what the issue is, but each fact when pulled is a mashup of other facts (ippos. A group of ravens i)

gfwilliams · 2025-09-02T15:09:44Z

That would have been handy to know in the PR!

You need to run this code and use the idx and count values it prints:

BangleApps/apps/textfacts/lib.js

Lines 6 to 21 in 4bb0e47

    
             /* 
        
             var s = require("Storage").read("textsource.txt"); 
        
             var idx = s.indexOf("\n"); 
        
             var lengths = [idx]; 
        
             while (idx>=0) { 
        
               var next = s.indexOf("\n",idx+1); 
        
               if (next>=0) { 
        
                 var len = next-idx; 
        
                 if (len>255) throw new Error("Line too long!"); 
        
                 lengths.push(len); 
        
               } 
        
               idx = next; 
        
             } 
        
             print(`Count = ${lengths.length}`); 
        
             print(`var idxs = E.toUint8Array(atob("${btoa(lengths)}"));`);*/

I guess you did run them before, but count is 237 and yet there are 316 lines so I guess maybe it was run on out of date data?

gfwilliams · 2025-12-05T09:05:20Z

@RKBoss6 any chance of fixing this? If you run the code again with the new data and update the library file it should be fine

RKBoss6 · 2025-12-05T17:24:00Z

Oh yeah, I had put this aside for a while, I'll get this working :)

RKBoss6 · 2025-12-05T18:12:13Z

I think it's fixed now!

Copilot

Pull request overview

This PR aims to expand the textfacts module from 162 to 316 fun facts while removing redundant entries. The version is bumped from 0.02 to 0.03, and the description is simplified to remove specific references to Google Gemini and the previous fact count.

Key changes:

Updated fact count from 162 to 316 in lib.js
Refreshed the base64-encoded index data for fact retrieval
Replaced and expanded the facts list with new content

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 37 comments.

File	Description
apps/textfacts/metadata.json	Version bumped to 0.03 and description simplified
apps/textfacts/lib.js	Updated getCount() to return 316 and refreshed base64-encoded fact indices
apps/textfacts/facts.txt	Replaced 162 facts with 316 new facts, though extensive duplicates remain
apps/textfacts/ChangeLog	Added entry documenting version 0.03 changes

Critical Issue: Despite the PR description stating that "redundant facts" were removed, the facts.txt file contains extensive duplication. Many facts appear 2-3 times throughout the file (e.g., lines 32-143 are largely duplicated in later sections). Additionally, line 214 contains a meta-comment that shouldn't be displayed as a fact, and several facts have missing punctuation (commas). These issues significantly undermine the stated goal of removing redundancy.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/textfacts/facts.txt

Copilot · 2025-12-05T18:23:30Z

apps/textfacts/facts.txt

+Your tongue is the only muscle in your body that is not attached at both ends
+The total number of stars in the universe is more than all the grains of sand on Earth
+A bolt of lightning is five times hotter than the surface of the sun
+A group of jellyfish is called a smack


This fact appears multiple times in the file (lines 41, 129). The PR aims to remove redundant facts, but this duplicate was not removed.

Copilot · 2025-12-05T18:23:30Z

apps/textfacts/facts.txt

+A bolt of lightning is five times hotter than the surface of the sun
+A group of jellyfish is called a smack
+There's a planet made largely of diamonds, 55 Cancri e
+Hawaii is moving towards Japan at the rate of a few inches per year


This fact appears multiple times in the file (lines 43, 131). The PR aims to remove redundant facts, but this duplicate was not removed.

Copilot · 2025-12-05T18:23:30Z

apps/textfacts/facts.txt

+The total weight of all the plastic in the ocean is estimated to be over 150 million tons
+There are more chickens than people in the world
+The average person walks 7,500 steps a day
+The national animal of North Korea is the Chollima a mythical winged horse


Missing comma before "a mythical winged horse" for proper punctuation.

Suggested change

The national animal of North Korea is the Chollima a mythical winged horse

The national animal of North Korea is the Chollima, a mythical winged horse

Copilot · 2025-12-05T18:23:31Z

apps/textfacts/facts.txt

+A group of owls is called a parliament
+Cows moo with regional accents
+There are more possible chess game permutations than atoms in the observable universe
+A "butt" was a medieval unit of measurement for wine


This fact appears three times in the file (lines 84, 172, 228). The PR aims to remove redundant facts, but these duplicates were not removed.

Suggested change

A "butt" was a medieval unit of measurement for wine

Copilot · 2025-12-05T18:23:38Z

apps/textfacts/facts.txt

+Some fungi glow in the dark
+The inventor of the stop sign was a woman
+The Earth's atmosphere is about 100 kilometers thick
+A group of armadillos is called a roll


This fact appears three times in the file (lines 116, 204, 308). The PR aims to remove redundant facts, but these duplicates were not removed.

Copilot · 2025-12-05T18:23:39Z

apps/textfacts/facts.txt

+The smallest bone in the human body is the stapes bone in the ear
+The world's largest snowflake on record was 15 inches wide and 8 inches thick
+There are more unique ways to shuffle a deck of cards than there are atoms on Earth
+A group of hedgehogs is called an array


This fact appears three times in the file (lines 106, 194, 311). The PR aims to remove redundant facts, but these duplicates were not removed.

Copilot · 2025-12-05T18:23:39Z

apps/textfacts/facts.txt

+The Great Pyramid of Giza was originally covered in highly polished white limestone
+The total mass of all the bacteria on Earth is greater than that of all animals combined
+The smell of books is called bibliosmia
+The highest point on Earth is Mount Everest but the highest point from the Earth's center is Mount Chimborazo


Missing comma before "but" for proper punctuation.

Suggested change

The highest point on Earth is Mount Everest but the highest point from the Earth's center is Mount Chimborazo

The highest point on Earth is Mount Everest, but the highest point from the Earth's center is Mount Chimborazo

Copilot · 2025-12-05T18:23:39Z

apps/textfacts/facts.txt

+The Earth's core is as hot as the surface of the sun
+A group of sloths is called a bed
+The average person will produce enough saliva in their lifetime to fill two swimming pools
+The smallest bone in the human body is the stapes bone in the ear


This fact appears three times in the file (lines 103, 191, 230). The PR aims to remove redundant facts, but these duplicates were not removed.

Copilot · 2025-12-05T18:23:39Z

apps/textfacts/facts.txt

+The only food that doesn't spoil is honey
+There are more trees on Earth than stars in the Milky Way galaxy
+The sound of a whip cracking is actually a tiny sonic boom
+There are more than 2,000 thunderstorms happening on Earth at any given moment


This fact appears multiple times in the file (lines 50, 137). The PR aims to remove redundant facts, but this duplicate was not removed.

Co-authored-by: Copilot <[email protected]>

Removed the fact about jellyfish being called a smack.

Co-authored-by: Copilot <[email protected]>

Add new facts, remove redundant ones

876cdbb

RKBoss6 marked this pull request as draft June 26, 2025 01:25

RKBoss6 marked this pull request as ready for review June 26, 2025 01:25

RKBoss6 marked this pull request as draft June 26, 2025 01:25

RKBoss6 marked this pull request as ready for review June 26, 2025 01:25

RKBoss6 added 6 commits June 27, 2025 19:41

Update ChangeLog

a92f75b

Update metadata.json

d7ab3ec

Add more facts

d674bd3

Update lib.js

67a9522

Update lib.js

c62de22

Update lib.js

67f04a5

RKBoss6 marked this pull request as draft June 27, 2025 23:59

RKBoss6 and others added 4 commits August 21, 2025 15:57

add a comma after every fact, to replace using atob

bf6854c

Removed duplicate facts and added new interesting facts to the list.

Reverse previous commit

ef5718e

Update return value and encoded string in lib.js

4f9643b

Merge branch 'espruino:master' into funFacts

4bb0e47

Update return value and encoded data in lib.js

f1f1ed4

RKBoss6 marked this pull request as ready for review December 5, 2025 18:12

Copilot AI review requested due to automatic review settings December 5, 2025 18:12

Copilot started reviewing on behalf of RKBoss6 December 5, 2025 18:13 View session

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Add clkinfo.js for displaying fun facts

58c0b21

RKBoss6 and others added 4 commits December 5, 2025 13:38

Update metadata description and add clkinfo module

f0394a8

Update apps/textfacts/facts.txt

b2066ea

Co-authored-by: Copilot <[email protected]>

Remove jellyfish fact from facts.txt

5907a78

Removed the fact about jellyfish being called a smack.

Apply suggestion from @Copilot

717ed3d

Co-authored-by: Copilot <[email protected]>

	The national animal of North Korea is the Chollima a mythical winged horse
	The national animal of North Korea is the Chollima, a mythical winged horse

	The highest point on Earth is Mount Everest but the highest point from the Earth's center is Mount Chimborazo
	The highest point on Earth is Mount Everest, but the highest point from the Earth's center is Mount Chimborazo

Add new fun facts to Fact list #3905

Are you sure you want to change the base?

Add new fun facts to Fact list #3905

Conversation

RKBoss6 commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gfwilliams commented Sep 2, 2025

Uh oh!

RKBoss6 commented Sep 2, 2025

Uh oh!

gfwilliams commented Sep 2, 2025

Uh oh!

gfwilliams commented Dec 5, 2025

Uh oh!

RKBoss6 commented Dec 5, 2025

Uh oh!

RKBoss6 commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RKBoss6 commented Jun 26, 2025 •

edited

Loading