PR to fix issue_164 #1
Conversation
Signed-off-by: aschemmel-tech <[email protected]>
…h-patch-2 Improvement: Add types details to requirements_concept
| Element out of Context (**SEooC**) (green box, top, 1 column). The objectives of the platform are | ||
| expressed as concrete **Stakeholder Requirements** (blue box, top, 2nd column), which can be tested | ||
| by provided **Platform Tests** (blue box, top, 5nd column) for reference hardware platforms. The | ||
| by provided **platform integration tests** (blue box, top, 5nd column) for reference hardware platforms. The |
There was a problem hiding this comment.
Maybe we take Platform Integration Tests as they are kind of a fixed statement and it would match also line 29 which calls it Stakeholder Requirements and not stakeholder requirements
| * - Requirements Type | ||
| - The requirement type defines which category the requirement relates to. Following categories are defined: [Functional, Interface, Process, Non-Functional] | ||
|
|
||
| - Functional: If implemented can be verified by a test (unit, integration) |
There was a problem hiding this comment.
This is a good addition, but it may be an additional change not related to the ticket.
If we get additional comments on this, the simple change of words would be delayed due to new content being provided. A split could make sense. Let us have a quick chat about it.
process/process_areas/verification/guidance/verification_process_toolreqs.rst
Show resolved
Hide resolved
| :complies: std_wp__iso26262__support_952 | ||
|
|
||
| Platform Testing verifies Stakeholder Requirements performed on reference HW. | ||
| platform integration testing verifies Stakeholder Requirements performed on reference HW. |
There was a problem hiding this comment.
Definitely here we need a capital P as it is a start of a sentence.
Based on your description "fix wording" you could have a naming description like changing the wording to platform integration test to match it to the wording of other artifacts. |
| Element out of Context (**SEooC**) (green box, top, 1 column). The objectives of the platform are | ||
| expressed as concrete **Stakeholder Requirements** (blue box, top, 2nd column), which can be tested | ||
| by provided **platform integration tests** (blue box, top, 5nd column) for reference hardware platforms. The | ||
| by provided **Platform Integration Tests** (blue box, top, 5nd column) for reference hardware platforms. The |
Deepa1-Patil
force-pushed
the
feature/issue_164_rename_platform_test
branch
from
a5f46ed to
e10154a
Compare
|
We cannot modify our main branch here. Please retarget the PR to where it should go. |
resolves: eclipse-score#164 Signed-off-by: Patil Deepa (ETAS-ECM/XPC-Fe2) <[email protected]>
Deepa1-Patil
force-pushed
the
feature/issue_164_rename_platform_test
branch
from
e10154a to
8235b8c
Compare
We do not want to merge this. We wanted to have upfront review on changes, before we go to S-CORE unprepared. This PR will be closed very soon. |
|
PR transferred to S-CORE project as internal review successfully conducted. |
fix wording