Skip to content

Conversation

@hwdef
Copy link
Contributor

@hwdef hwdef commented Nov 19, 2025

Ref: #18667 #20545

This PR adds a benchmark for txn_put_get, specifically tailored for issue #18667.

Regarding the original issue, there are some existing solutions. However, we are concerned that they might impact performance. The challenge is that we currently lack a dedicated benchmark case to quantify the extent of this potential impact. Some discussions in #20545

The key to this benchmark case is to perform both the PUT and GET within a single transaction while utilizing a prefix query. This way, when there is ahrtr@76ac23f, the GET/RANGE requests can not be skipped, which degraded performance, and vice versa.

I'll attach the benchmark results shortly.

cc @siyuanfoundation @serathius @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hwdef
Once this PR has been reviewed and has the lgtm label, please assign siyuanfoundation for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.30%. Comparing base (bc12c94) to head (1833b61).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20953      +/-   ##
==========================================
+ Coverage   69.20%   69.30%   +0.10%     
==========================================
  Files         422      422              
  Lines       34841    34841              
==========================================
+ Hits        24110    24148      +38     
+ Misses       9330     9300      -30     
+ Partials     1401     1393       -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc12c94...1833b61. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hwdef
Copy link
Contributor Author

hwdef commented Nov 20, 2025

/retest

@hwdef
Copy link
Contributor Author

hwdef commented Nov 20, 2025

/test pull-etcd-unit-test-arm64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants