Skip to content

Conversation

@Elbehery
Copy link
Member

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Mustafa Elbehery <[email protected]>
@Elbehery Elbehery force-pushed the 20250617-add-gci-formatter branch from c61d758 to 4ddef6d Compare June 17, 2025 12:52
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @Elbehery. It looks like you're bumping golangci lint to v2, which is incompatible with the configuration file. Could you revert this, to fix the CI failure? Thanks again :)

@Elbehery
Copy link
Member Author

Thanks @ivanvc

So I had to bump golangci lint, so that I can add gci

you find details in this CI run

@ivanvc
Copy link
Member

ivanvc commented Jun 20, 2025

If you do so, you need to update the configuration file. Please review the CI failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants