This repository was archived by the owner on Apr 12, 2021. It is now read-only.
feat: Have ExecutionManager pass data up#342
Draft
smartcontracts wants to merge 6 commits intomasterfrom
Draft
Conversation
Collaborator
Author
|
|
smartcontracts
added
Category: Enhancement
maurelian
reviewed
Mar 24, 2021
contracts/optimistic-ethereum/OVM/predeploys/OVM_SequencerEntrypoint.sol
Show resolved
Hide resolved
maurelian
reviewed
Mar 25, 2021
| @@ -355,10 +372,6 @@ library Lib_SafeExecutionManagerWrapper { | |||
| assembly { | |||
| revert(add(returndata, 0x20), mload(returndata)) | |||
Collaborator
There was a problem hiding this comment.
I know it's outside of scope, but why does this need assembly?
Collaborator
|
@smartcontracts Can you confirm that this PR is fully backwards compatible? |
Collaborator
Author
I do not think this PR is fully backwards compatible. So we're going to have to keep this one open for a little. |
smartcontracts
added
Status: Mergeable; Breaking
Breaks: Geth L2
and removed
Status: Needs Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures that
OVM_ExecutionManagerwill pass data upwards. Also modifiesOVM_ProxyEOAandOVM_SequencerEntrypointto pass data upwards and out of the EM.Additional context
Vastly simplifies the process of giving users relevant return data in Geth. Cuts a lot of code out of
evm.go.Metadata