-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Spec 6s slot times (EIP-7782) #4484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dankrad
wants to merge
32
commits into
ethereum:master
Choose a base branch
from
dankrad:dankrad-eip7782
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
ff1036c
Replace INTERVALS_PER_SLOT with explicit slot component times
jtraglia 130745c
Replace LATE_BLOCK_CUTOFF_BPS with ATTESTATION_DUE_BPS
jtraglia 4d93844
Update eip7805 specs
jtraglia 21e0ef4
Rename eip7805 time params for consistency
jtraglia d6fa5ea
Slot time update
dankrad 2abb059
Typo
dankrad 860479b
Slot subdivisions and configs
dankrad 308b42a
Base reward update
dankrad 2aa192d
Blob schedule
dankrad 2e292be
Add churn limit updates
dankrad afc83f0
toc
dankrad 8f22a08
Fix blob schedule
jtraglia f6f869b
Run make lint
jtraglia 0d381c4
Remove fork check conditions
jtraglia 1725283
Add backend support for eip7782
jtraglia 4d24d40
Make some fixes
jtraglia e776aa5
Merge branch 'master' into dankrad-eip7782
jtraglia cfbff41
Update todo comment
jtraglia 312bef5
Merge branch 'master' into dankrad-eip7782
jtraglia 370840f
Add get_forkchoice_store
dankrad 4a29a82
Merge branch 'master' into dankrad-eip7782
jtraglia 490cf8c
Clean up config variables
jtraglia 24f67e7
Remove duplicate function
jtraglia fc61023
Use pre.proposer_lookahead in upgrade
jtraglia fd1277c
Merge branch 'master' into dankrad-eip7782
jtraglia 0214feb
Fix sync committee period
dankrad 16e5872
Add sync period functions
dankrad ea877a8
Merge branch 'master' into dankrad-eip7782
dankrad 3af084e
on_tick logic
dankrad 6a36694
Simplify get_sync_committee_period_at_slot
dankrad 67f7ad2
Merge branch 'master' into dankrad-eip7782
dankrad 5516c49
Add slot subdivision variables and getters
dankrad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dankrad these modifications don't match the way we do this elsewhere. Like:
consensus-specs/specs/gloas/fork-choice.md
Lines 440 to 444 in f0b3bca
For this function, it should be:
And we need to update
get_slot_component_duration_msto be:At the fork, the updated
get_slot_component_duration_mswill be used. It doesn't need to know the epoch.