trie: add sub-trie iterator support #32520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
reviewed
Aug 30, 2025
gballet
reviewed
Sep 1, 2025
gballet
reviewed
Sep 1, 2025
gballet
reviewed
Sep 1, 2025
MariusVanDerWijden
changed the title
Member
|
@samuelarogbonlo Please check out the commit i have made on the top rjl493456442@3dfd6cd Please let me know if it's ok to you, so that I can push it into your branch. |
Contributor
Author
Would check now |
Contributor
Author
Yes, please @rjl493456442 push it to the branch, it loosk good and has a clean structure, try to test as well or I could do it for you |
- Remove separate prefixIterator type per reviewer feedback - Add prefix and stop fields directly to nodeIterator - Implement proper subtree boundaries with both start and stop points - Simplify maintenance by avoiding unnecessary new types Co-authored-by: gballet <[email protected]>
rjl493456442
force-pushed
the
sam/trie
branch
from
3dfd6cd to
45ee2fb
Compare
rjl493456442
approved these changes
Sep 17, 2025
Sahil-4555
pushed a commit
to Sahil-4555/go-ethereum
that referenced
this pull request
Oct 12, 2025
- Adds `NodeIteratorWithPrefix()` method to support iterating only nodes
within a specific key prefix
- Adds `NodeIteratorWithRange()` method to support iterating only nodes
within a specific key range
Current `NodeIterator` always traverses the entire remaining trie from a
start position. For non-ethereum applications using the trie implementation,
there's no way to limit iteration to just a subtree with a specific prefix.
**Usage:**
```go
// Only iterate nodes with prefix "key1"
iter, err := trie.NodeIteratorWithPrefix([]byte("key1"))
```
Testing: Comprehensive test suite covering edge cases and boundary conditions.
Closes ethereum#32484
---------
Co-authored-by: gballet <[email protected]>
Co-authored-by: Gary Rong <[email protected]>
atkinsonholly
pushed a commit
to atkinsonholly/ephemery-geth
that referenced
this pull request
Nov 24, 2025
- Adds `NodeIteratorWithPrefix()` method to support iterating only nodes
within a specific key prefix
- Adds `NodeIteratorWithRange()` method to support iterating only nodes
within a specific key range
Current `NodeIterator` always traverses the entire remaining trie from a
start position. For non-ethereum applications using the trie implementation,
there's no way to limit iteration to just a subtree with a specific prefix.
**Usage:**
```go
// Only iterate nodes with prefix "key1"
iter, err := trie.NodeIteratorWithPrefix([]byte("key1"))
```
Testing: Comprehensive test suite covering edge cases and boundary conditions.
Closes ethereum#32484
---------
Co-authored-by: gballet <[email protected]>
Co-authored-by: Gary Rong <[email protected]>
prestoalvarez
pushed a commit
to prestoalvarez/go-ethereum
that referenced
this pull request
Nov 27, 2025
- Adds `NodeIteratorWithPrefix()` method to support iterating only nodes
within a specific key prefix
- Adds `NodeIteratorWithRange()` method to support iterating only nodes
within a specific key range
Current `NodeIterator` always traverses the entire remaining trie from a
start position. For non-ethereum applications using the trie implementation,
there's no way to limit iteration to just a subtree with a specific prefix.
**Usage:**
```go
// Only iterate nodes with prefix "key1"
iter, err := trie.NodeIteratorWithPrefix([]byte("key1"))
```
Testing: Comprehensive test suite covering edge cases and boundary conditions.
Closes ethereum#32484
---------
Co-authored-by: gballet <[email protected]>
Co-authored-by: Gary Rong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeIteratorWithPrefix()method to support iterating only nodes within a specific key prefixNodeIteratorWithRange()method to support iterating only nodes within a specific key rangeCurrent
NodeIteratoralways traverses the entire remaining trie from a start position.For non-ethereum applications using the trie implementation, there's no way to limit
iteration to just a subtree with a specific prefix.
Usage:
Testing: Comprehensive test suite covering edge cases and boundary conditions.
Closes #32484