core/txpool/blobpool: cell level blobpool #32583
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healthykim
force-pushed
the
bs/cell-blobpool/ver-1
branch
from
d3cb961 to
721fd79
Compare
healthykim
force-pushed
the
bs/cell-blobpool/ver-1
branch
from
27e2694 to
cfee930
Compare
healthykim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements cell-storing logic in the blob pool.
Changes
PooledTxtype for data stored in the blobpoolBlobTxCellSidecartypeThe conversion from
types.Transactionin the database to thepooledTxtypeoccurs inside the
Init()function.Considering that the current blobpool maintains roughly 4 MB of blob transactions,
the maximum number of blobs would be around 32.
Given that the EC operation on a single blob takes about 1.5 ms,
the overhead in this average case seems be acceptable.
Also possible option:
Since parity cells are currently being discarded (otherwise we would have to store twice as much data),
the stored cells are simply the result of splitting the blob.
We can modify the computeCells function to take a removeParity parameter so that when it is set to true,
the function only performs the split without any additional computation.
Similarly, recoverBlob is equivalent to concatenating the cells, so the same approach can be applied there as well.