Skip to content

eth/filters: execute different subscriptions in parallel #32966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

eth/filters: execute different subscriptions in parallel #32966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2005bf6
execute different subscription in parallel way
mask-pp Oct 19, 2025
4f12b60
fix bug
mask-pp Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions eth/filters/filter_system.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import (
"github.com/ethereum/go-ethereum/log"
"github.com/ethereum/go-ethereum/params"
"github.com/ethereum/go-ethereum/rpc"
"golang.org/x/sync/errgroup"
)

// Config represents the configuration of the filter system.
Expand Down Expand Up @@ -439,17 +440,25 @@ func (es *EventSystem) handleTxsEvent(filters filterIndex, ev core.NewTxsEvent)
}

func (es *EventSystem) handleChainEvent(filters filterIndex, ev core.ChainEvent) {
for _, f := range filters[BlocksSubscription] {
f.headers <- ev.Header
}
var eg errgroup.Group
eg.Go(func() error {
for _, f := range filters[BlocksSubscription] {
f.headers <- ev.Header
}
return nil
})

// Handle transaction receipts subscriptions when a new block is added
for _, f := range filters[TransactionReceiptsSubscription] {
matchedReceipts := filterReceipts(f.txHashes, ev)
if len(matchedReceipts) > 0 {
f.receipts <- matchedReceipts
eg.Go(func() error {
// Handle transaction receipts subscriptions when a new block is added
for _, f := range filters[TransactionReceiptsSubscription] {
matchedReceipts := filterReceipts(f.txHashes, ev)
if len(matchedReceipts) > 0 {
f.receipts <- matchedReceipts
}
}
}
return nil
})
_ = eg.Wait()
}

// eventLoop (un)installs filters and processes mux events.
Expand Down