Skip to content
This repository was archived by the owner on Aug 8, 2018. It is now read-only.

Fixes solidity warnings#227

Open
AndreMiras wants to merge 1 commit intoethereum:developfrom
AndreMiras:feature/solidity_warning_fix
Open

Fixes solidity warnings#227
AndreMiras wants to merge 1 commit intoethereum:developfrom
AndreMiras:feature/solidity_warning_fix

Conversation

@AndreMiras
Copy link

Two tests updated:

  • test_console_name_reg_contract()
  • test_compile_solidity()

The warning was: "solc_wrapper is deprecated, ..."

Two tests updated:

  - test_console_name_reg_contract()
  - test_compile_solidity()

The warning was: "solc_wrapper is deprecated, ..."
@AndreMiras
Copy link
Author

OK after writing the code of #226, some warning popped up.
They were not show before because the code was skip/xfail, but with #226 since it's now executing, the warning are showing.
Also I could integrated the warning fixes in #226, but I prefer to do it in a different pull request, just in case you don't want to integrate the warning fixes (since it makes the code more verbose).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 49.617% when pulling bc1a2ad on AndreMiras:feature/solidity_warning_fix into ba0da2f on ethereum:develop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants