This repository was archived by the owner on Aug 8, 2018. It is now read-only.
Use str() instead of to_string(), as to_string() sometimes returns bytes#284
Open
robin-norwood wants to merge 1 commit intoethereum:developfrom
Open
Use str() instead of to_string(), as to_string() sometimes returns bytes#284robin-norwood wants to merge 1 commit intoethereum:developfrom
robin-norwood wants to merge 1 commit intoethereum:developfrom
Conversation
Author
|
FYI, I don't think the Travis failure is due to this change - it looks like setuptools has deprecated the use of sets in requires. I'll submit a separate pull request for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyethapp account listwas giving the following error:This is because, on python 3, ethereum.utils.to_string() will, when given an integer, return bytes (!).
ethereum.utils.to_string should probably also be fixed, or at least given a more correct name, but that's more work than I'm willing to take on right now.