Reading zisk info from yaml #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks a lot Roger! Any chance we can update this PR to use toml instead of yaml? I feel like toml is a more human readable format, that also allows us to add inline comments. I have an example here. Later down the road, we should think how to better incorporate these config files from the upstream repo, using some sort of CI pipeline. But we can leave that for a future PR. Let me know what you think! |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a .yaml with the configuration of all AIRs used in a Zisk proof and modifies zisk.py so that information is direclty read from yaml file.
It also contains all the necessary instructions to generate the yaml file given a Zisk setup