Skip to content

Conversation

@holgerd77
Copy link
Member

When building a new package-lock.json file with npm >= 10.3 (I know used 11.6.2, maybe we can somewhat align here), to solve the optional dependency problems (biome!) mentioned in #4150, various CI problems bubble up:

grafik

(this is a screenshot from the Fusaka/Osaka PR). This is too much to be solved on the sideline, especially since looking into CI logs reveal that problems are not necessarily related. Not fully sure what causes this yet, maybe partially things like ESLint version updates with some slightly modified rules e.g..

We'll see.

PR is open to be picked-up/continued (I will still do during today/Friday), then please drop a note in chat!

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.79%. Comparing base (428ffe2) to head (06425c6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 87.58% <ø> (ø)
blockchain 89.37% <100.00%> (+0.01%) ⬆️
common 97.43% <ø> (ø)
evm 72.39% <ø> (ø)
mpt 90.00% <ø> (+0.25%) ⬆️
statemanager 80.21% <ø> (ø)
static 99.77% <ø> (ø)
tx 90.04% <ø> (ø)
util 88.88% <ø> (ø)
vm 57.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@holgerd77
Copy link
Member Author

Ok, I'll take this in, this is all pretty undisputable even with a somewhat larger change set, and I assume it makes various parts of tooling less brittle, e.g. the strange linting behavior in between, also tsc which was not catching stuff before.

Browser tests still fail, this seems to some vitest update/bug, getting too much for here, this should be addressed separately, might be already by some mild vitest version update.

@holgerd77 holgerd77 merged commit be0c4f6 into master Oct 17, 2025
32 of 33 checks passed
@holgerd77 holgerd77 deleted the fix-various-ci-problems branch October 17, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant