AutoTLS implementation + AutoNAT removed #5176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nugaon
reviewed
Aug 4, 2025
pkg/p2p/libp2p/libp2p.go
Outdated
| // Use AutoTLS storage dir | ||
| storagePath := o.AutoTLSStorageDir | ||
| if storagePath == "" { | ||
| storagePath = filepath.Join("./", "p2p-forge-certs") // Fallback to ./p2p-forge-certs |
Member
There was a problem hiding this comment.
it may be better to be part of the config module and in a different directory.
martinconic
changed the title
martinconic
changed the title
Contributor
Author
|
Change this to draft since removing the existing AutoNAT implementation should be a task on its own. |
Contributor
Author
|
Since this also includes experimentation with removing old Autonat code , for now we should have this closed and go only with PR-5187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
AutoTLS implementation
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):