Skip to content

test(storer-reserve): add synctest in evict test #5263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+55 −55
Open

test(storer-reserve): add synctest in evict test #5263

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2c0c6e
test(storer-reserve): add synctest in evict test
akrem-chabchoub Oct 29, 2025
f1fe549
fix(tests): add missing newline at end of reserve_test.go
akrem-chabchoub Oct 29, 2025
6503129
refactor(tests): update test commands in Makefile to run all tests in…
akrem-chabchoub Nov 23, 2025
0ad8a61
refactor(tests): replace time.Sleep with synctest.Wait in TestEvict
akrem-chabchoub Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 55 additions & 55 deletions pkg/storer/internal/reserve/reserve_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"math"
"math/rand"
"testing"
"time"
"testing/synctest"

"github.com/ethersphere/bee/v2/pkg/crypto"
"github.com/ethersphere/bee/v2/pkg/log"
Expand Down Expand Up @@ -531,77 +531,77 @@ func TestReplaceOldIndex(t *testing.T) {
}

func TestEvict(t *testing.T) {
t.Parallel()
synctest.Test(t, func(t *testing.T) {
baseAddr := swarm.RandAddress(t)

baseAddr := swarm.RandAddress(t)
ts := internal.NewInmemStorage()

ts := internal.NewInmemStorage()
chunksPerBatch := 50
var chunks []swarm.Chunk
batches := []*postage.Batch{postagetesting.MustNewBatch(), postagetesting.MustNewBatch(), postagetesting.MustNewBatch()}
evictBatch := batches[1]

chunksPerBatch := 50
var chunks []swarm.Chunk
batches := []*postage.Batch{postagetesting.MustNewBatch(), postagetesting.MustNewBatch(), postagetesting.MustNewBatch()}
evictBatch := batches[1]
r, err := reserve.New(
baseAddr,
ts,
0, kademlia.NewTopologyDriver(),
log.Noop,
)
if err != nil {
t.Fatal(err)
}

r, err := reserve.New(
baseAddr,
ts,
0, kademlia.NewTopologyDriver(),
log.Noop,
)
if err != nil {
t.Fatal(err)
}
for range chunksPerBatch {
for b := range 3 {
ch := chunk.GenerateTestRandomChunkAt(t, baseAddr, b).WithStamp(postagetesting.MustNewBatchStamp(batches[b].ID))
chunks = append(chunks, ch)
err := r.Put(context.Background(), ch)
if err != nil {
t.Fatal(err)
}
}
}

for range chunksPerBatch {
for b := range 3 {
ch := chunk.GenerateTestRandomChunkAt(t, baseAddr, b).WithStamp(postagetesting.MustNewBatchStamp(batches[b].ID))
chunks = append(chunks, ch)
err := r.Put(context.Background(), ch)
totalEvicted := 0
for i := range 3 {
evicted, err := r.EvictBatchBin(context.Background(), evictBatch.ID, math.MaxInt, uint8(i))
if err != nil {
t.Fatal(err)
}
totalEvicted += evicted
}
}

totalEvicted := 0
for i := range 3 {
evicted, err := r.EvictBatchBin(context.Background(), evictBatch.ID, math.MaxInt, uint8(i))
if err != nil {
t.Fatal(err)
if totalEvicted != chunksPerBatch {
t.Fatalf("got %d, want %d", totalEvicted, chunksPerBatch)
}
totalEvicted += evicted
}

if totalEvicted != chunksPerBatch {
t.Fatalf("got %d, want %d", totalEvicted, chunksPerBatch)
}
synctest.Wait()

time.Sleep(time.Second)

for i, ch := range chunks {
binID := i%chunksPerBatch + 1
b := swarm.Proximity(baseAddr.Bytes(), ch.Address().Bytes())
stampHash, err := ch.Stamp().Hash()
if err != nil {
t.Fatal(err)
}
_, err = r.Get(context.Background(), ch.Address(), ch.Stamp().BatchID(), stampHash)
if bytes.Equal(ch.Stamp().BatchID(), evictBatch.ID) {
if !errors.Is(err, storage.ErrNotFound) {
t.Fatalf("got err %v, want %v", err, storage.ErrNotFound)
}
checkStore(t, ts.IndexStore(), &reserve.BatchRadiusItem{Bin: b, BatchID: ch.Stamp().BatchID(), Address: ch.Address(), StampHash: stampHash}, true)
checkStore(t, ts.IndexStore(), &reserve.ChunkBinItem{Bin: b, BinID: uint64(binID), StampHash: stampHash}, true)
checkChunk(t, ts, ch, true)
} else {
for i, ch := range chunks {
binID := i%chunksPerBatch + 1
b := swarm.Proximity(baseAddr.Bytes(), ch.Address().Bytes())
stampHash, err := ch.Stamp().Hash()
if err != nil {
t.Fatal(err)
}
checkStore(t, ts.IndexStore(), &reserve.BatchRadiusItem{Bin: b, BatchID: ch.Stamp().BatchID(), Address: ch.Address(), StampHash: stampHash}, false)
checkStore(t, ts.IndexStore(), &reserve.ChunkBinItem{Bin: b, BinID: uint64(binID), StampHash: stampHash}, false)
checkChunk(t, ts, ch, false)
_, err = r.Get(context.Background(), ch.Address(), ch.Stamp().BatchID(), stampHash)
if bytes.Equal(ch.Stamp().BatchID(), evictBatch.ID) {
if !errors.Is(err, storage.ErrNotFound) {
t.Fatalf("got err %v, want %v", err, storage.ErrNotFound)
}
checkStore(t, ts.IndexStore(), &reserve.BatchRadiusItem{Bin: b, BatchID: ch.Stamp().BatchID(), Address: ch.Address(), StampHash: stampHash}, true)
checkStore(t, ts.IndexStore(), &reserve.ChunkBinItem{Bin: b, BinID: uint64(binID), StampHash: stampHash}, true)
checkChunk(t, ts, ch, true)
} else {
if err != nil {
t.Fatal(err)
}
checkStore(t, ts.IndexStore(), &reserve.BatchRadiusItem{Bin: b, BatchID: ch.Stamp().BatchID(), Address: ch.Address(), StampHash: stampHash}, false)
checkStore(t, ts.IndexStore(), &reserve.ChunkBinItem{Bin: b, BinID: uint64(binID), StampHash: stampHash}, false)
checkChunk(t, ts, ch, false)
}
}
}
})
}

func TestEvictSOC(t *testing.T) {
Expand Down
Loading