Skip to content

Conversation

@Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented May 28, 2025

Problem Description
Swaps out the DubinsAirplane statespace to the implementation in OMPL: ompl/ompl#1210

@srmainwaring FYI

@Jaeyoung-Lim Jaeyoung-Lim changed the title Switch to upstream OMPL Dubins Airplane Statespace [WIP] Switch to upstream OMPL Dubins Airplane Statespace May 28, 2025
@Jaeyoung-Lim Jaeyoung-Lim force-pushed the pr-ompl-dubins-airplane branch from 9ef6291 to a25304b Compare May 28, 2025 04:21
Use upstream owen statespace

F

Use upstream owen statespace

F

F

F
@Jaeyoung-Lim Jaeyoung-Lim force-pushed the pr-ompl-dubins-airplane branch from 67803dd to 0ee3bf8 Compare June 2, 2025 01:59
Copy link
Collaborator

@Ryanf55 Ryanf55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good migration. Have you considered deleting the unused code before merge?

@Jaeyoung-Lim
Copy link
Member Author

@Ryanf55 Thanks for the review! Would you have any clue on why the CI is failing?

@Jaeyoung-Lim Jaeyoung-Lim force-pushed the pr-ompl-dubins-airplane branch from ecc0b0d to 08a44a7 Compare June 2, 2025 06:38
@Jaeyoung-Lim Jaeyoung-Lim changed the title [WIP] Switch to upstream OMPL Dubins Airplane Statespace Switch to upstream OMPL Dubins Airplane Statespace Jun 3, 2025
@Jaeyoung-Lim Jaeyoung-Lim merged commit 9edc416 into ros2 Jun 3, 2025
1 of 3 checks passed
@Jaeyoung-Lim Jaeyoung-Lim deleted the pr-ompl-dubins-airplane branch June 3, 2025 08:30
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jun 4, 2025

@Ryanf55 Thanks for the review! Would you have any clue on why the CI is failing?

These were caused by upstream key issues and are now fixed.

@Jaeyoung-Lim
Copy link
Member Author

@Ryanf55 Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants