Skip to content

Commit fa4b8e2

Browse files
Merge pull request #83 from ethz-asl/feature/report_resource_usage
Report resource usage
2 parents d0d64d8 + f8cfa96 commit fa4b8e2

File tree

64 files changed

+791
-84
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+791
-84
lines changed

.github/pull_request_template.md

Lines changed: 75 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,99 @@
11
# Description
22

3-
Thank you for opening a PR. Please summarize the changes in 1 or 2 sentences.
3+
Thank you for opening a PR! Please summarize the changes in 12 sentences.
44

55
## Type of change
66

7-
Delete options that are not relevant.
8-
97
- [ ] Bug fix (non-breaking change which fixes an issue)
108
- [ ] New feature (non-breaking change which adds functionality)
11-
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
9+
- [ ] Breaking change (fix or feature that causes existing functionality to not work as expected)
10+
- [ ] Other (please describe):
11+
12+
## Detailed Summary
13+
14+
Provide the motivation, context, and links to any related issues, PRs, or documentation:
15+
16+
- Motivation: Why is this change necessary?
17+
- Context: How does it fit into wavemap's functionality?
18+
- Related issues/PRs: Fixes # (issue) / Links to other PRs
19+
20+
## API Changes
21+
22+
List any changes to wavemap's APIs to help users update their code. Write "None" if there are no changes.
23+
24+
### C++ API:
25+
26+
*
27+
28+
### Python API:
29+
30+
*
1231

13-
## Detailed summary
32+
### ROS1 Interface:
1433

15-
Please describe the motivation, context and a link to related issues (if appropriate). List any dependencies that are required for this change.
34+
*
1635

17-
Feel free to summarize the changes as a list of bullet points.
36+
## Review Notes
1837

19-
Fixes # (issue)
38+
Is there anything specific the reviewers should focus on, or are there unresolved questions? Mention them here.
2039

2140
# Testing
2241

23-
If possible, verify that the changes produce the desired results by extending the unit tests. If you would like us to help you with this, feel free to open the pull request already and let us know.
42+
### Automated Tests
2443

25-
If manual tests were performed to verify these changes, please describe them here and provide instructions to reproduce them. Please also list any relevant details for your test configuration below.
44+
Have you added or modified unit tests to verify these changes? If not, let us know if you'd like assistance.
2645

27-
If the changes are performance related, this is a good place to list the metrics that were used and the improvements that have been achieved.
46+
### Manual Tests
2847

29-
**System information (please complete if relevant):**
30-
- CPU: [e.g. Intel i9-9900K]
31-
- GPU: [e.g. Nvidia RTX 2080Ti] # Only for visualization-related issues
32-
- RAM: [e.g. 32GB]
33-
- OS: [e.g. Ubuntu 20.04]
34-
- Installation: [e.g., Native (ROS with catkin); or Docker]
48+
If manual tests were performed to verify these changes, describe them here and include instructions to reproduce them.
49+
Describe test configurations where applicable.
3550

36-
**Runtime information (please complete if relevant):**
37-
- Launch file: [e.g. Link to the launch file you used]
38-
- Config file: [e.g. Link to the config file you used]
39-
- Dataset name [e.g. Newer College Cloister sequence] # For public datasets
40-
- Custom setup: # For online use or personal datasets
41-
- Depth sensor: [e.g. Livox MID360 LiDAR]
42-
- Pose source: [e.g. Odometry from FastLIO2]
51+
**System information (optional):**
4352

44-
# Checklist:
53+
- CPU: [e.g., Intel i9-9900K]
54+
- GPU: [e.g., Nvidia RTX 2080Ti]
55+
- RAM: [e.g., 32GB]
56+
- OS: [e.g., Ubuntu 20.04]
57+
- API: [e.g., C++, Python, ROS1]
58+
- Installation: [e.g., pre-built Docker, local CMake, Pip, catkin]
59+
60+
**Runtime information (optional):**
61+
62+
- Launch file: [e.g., Link or GitHub Gist]
63+
- Config file: [e.g., Link or GitHub Gist]
64+
- Dataset name (if public): [e.g., Newer College Cloister]
65+
- Custom setup (for private datasets, or live usage):
66+
- Depth sensor: [e.g., Livox MID360 LiDAR]
67+
- Pose source: [e.g., Odometry from FastLIO2]
68+
69+
For performance or accuracy-related changes, include the above system and runtime information and describe:
70+
71+
- **Performance (optional)**
72+
- Measured operation: [e.g. serializing the map, performing 1M queries, processing dataset X]
73+
- Metrics [e.g., CPU time, wall time, total RAM usage]
74+
- **Accuracy (optional)**
75+
- Metrics: [e.g., AUC, accuracy, recall]
76+
- **Summary of changes**
77+
- What metrics improved and by how much?
78+
- Did any metrics worsen?
79+
80+
### Benchmarks (To be completed by maintainers)
81+
82+
We will rerun wavemap's benchmarks and report the results here to validate there are no general performance/accuracy regressions.
83+
84+
# Checklist
85+
86+
General
4587

4688
- [ ] My code follows the style guidelines of this project
4789
- [ ] I have performed a self-review of my code
4890
- [ ] I have commented my code, particularly in hard-to-understand areas
49-
- [ ] I have made corresponding changes to the documentation
91+
- [ ] I have added or updated tests as required
5092
- [ ] Any required changes in dependencies have been committed and pushed
93+
94+
Documentation (where applicable)
95+
96+
- [ ] I have updated the installation instructions (in docs/pages/installation)
97+
- [ ] I have updated the code's inline API documentation (e.g., docstrings)
98+
- [ ] I have updated the parameter documentation (in docs/pages/parameters)
99+
- [ ] I have updated/extended the tutorials (in docs/pages/tutorials)

examples/cpp/CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
Changelog for package wavemap_examples_cpp
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
2.1.2 (2024-11-20)
6+
------------------
7+
58
2.1.1 (2024-10-24)
69
------------------
710

examples/cpp/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.10)
2-
project(wavemap_examples_cpp VERSION 2.1.1 LANGUAGES CXX)
2+
project(wavemap_examples_cpp VERSION 2.1.2 LANGUAGES CXX)
33

44
# Load the wavemap library
55
# First, try to load it from sources

examples/python/CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
Changelog for package wavemap_examples_python
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
2.1.2 (2024-11-20)
6+
------------------
7+
58
2.1.1 (2024-10-24)
69
------------------
710

examples/ros1/CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
Changelog for package wavemap_examples_ros1
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
2.1.2 (2024-11-20)
6+
------------------
7+
58
2.1.1 (2024-10-24)
69
------------------
710
* Address warnings from new cpplint version (v2.0)

examples/ros1/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version='1.0' encoding='utf-8'?>
22
<package format="2">
33
<name>wavemap_examples_ros1</name>
4-
<version>2.1.1</version>
4+
<version>2.1.2</version>
55
<description>Usages examples for wavemap's ROS1 interface.</description>
66

77
<maintainer email="[email protected]">Victor Reijgwart</maintainer>

interfaces/ros1/wavemap/CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
Changelog for package wavemap
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
2.1.2 (2024-11-20)
6+
------------------
7+
58
2.1.1 (2024-10-24)
69
------------------
710

interfaces/ros1/wavemap/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version='1.0' encoding='utf-8'?>
22
<package format="2">
33
<name>wavemap</name>
4-
<version>2.1.1</version>
4+
<version>2.1.2</version>
55
<description>Base library for wavemap.</description>
66

77
<maintainer email="[email protected]">Victor Reijgwart</maintainer>

interfaces/ros1/wavemap_all/CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
Changelog for package wavemap_all
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
2.1.2 (2024-11-20)
6+
------------------
7+
58
2.1.1 (2024-10-24)
69
------------------
710

interfaces/ros1/wavemap_all/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version='1.0' encoding='utf-8'?>
22
<package format="2">
33
<name>wavemap_all</name>
4-
<version>2.1.1</version>
4+
<version>2.1.2</version>
55
<description>Metapackage that builds all wavemap packages.</description>
66

77
<maintainer email="[email protected]">Victor Reijgwart</maintainer>

0 commit comments

Comments
 (0)