Vehicles: remove title/icon from yaml config (BC)

[andig]

This PR removes the special case of vehicle having their "own" title and icon instead of title/icon being part of the device meta data. This has the following consequences:

• title/icon configuration via yaml is no longer possible- it is via config UI
• vehicle API nick names are removed (it was never clear if an API or given title had preference)
• this supported better OAuth user experience for Refactor provider authorization #24264

TODO

• remove UI special casing @naltatis

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• There’s a lot of repetitive withContext(ctx) boilerplate in each vehicle constructor—consider refactoring the registry.AddCtx wrapper to automatically inject context into embeds and reduce duplication.
• Instead of leaving large blocks of commented-out code (e.g. legacy site.Vehicles and Icon/SetTitle methods), remove them entirely to clean up the codebase and avoid confusion.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- There’s a lot of repetitive withContext(ctx) boilerplate in each vehicle constructor—consider refactoring the registry.AddCtx wrapper to automatically inject context into embeds and reduce duplication.
- Instead of leaving large blocks of commented-out code (e.g. legacy site.Vehicles and Icon/SetTitle methods), remove them entirely to clean up the codebase and avoid confusion.

## Individual Comments

### Comment 1
<location> `core/site_vehicles.go:87` </location>
<code_context>
 }

-var _ site.Vehicles = (*vehicles)(nil)
+// var _ site.Vehicles = (*vehicles)(nil)

-type vehicles struct {
</code_context>

<issue_to_address>
**issue (complexity):** Consider removing the commented-out code to improve code clarity and maintainability.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[naltatis]

@andig any chance we can keep supporting the deprecated yaml title/icon for a couple of releases? Since config ui is not marked as stable yet, there will be no non-experimental way to set a vehicle title. Having a vehicle title is much more critical from a user-base-perspective than meter titles.

If we can't support both, I'd say we should hold this PR until config ui is stable.

[naltatis]

this supported better OAuth user experience

Is the new vehicle title api really necessary for this? Publishing a vehicle name would also be fine for UI. We have everything there to perform a lookup for title.