Feature/parallel collation by SmaGMan · Pull Request #197 · everx-labs/ever-node

SmaGMan · 2023-12-23T09:13:45Z

No description provided.

Sumrachek · 2023-12-28T10:20:24Z

src/validator/collator.rs


        let rand_seed = rand_seed.unwrap_or_else(|| secure_256_bits().into());

+        let finalize_parallel_timeout_ms =


Looks like method of CollatorConfig

Sumrachek · 2023-12-28T10:40:25Z

src/validator/collator.rs

-            self.process_new_messages(!collator_data.inbound_queues_empty, prev_data, 
-                collator_data, &mut exec_manager).await?;
+            if collator_data.inbound_queues_empty {
+                self.process_new_messages(!collator_data.inbound_queues_empty, prev_data, 


Seems it is a good idea to delete the first parameter in the enqueue_only func and refactor it a bit.

Sumrachek · 2023-12-28T10:50:52Z

src/validator/collator.rs

        self.create_ticktock_transaction(config_account_id, tock, prev_data, collator_data, 
            exec_manager).await?;
-        exec_manager.wait_transactions(collator_data).await?;
+        exec_manager.wait_transactions(collator_data, || self.check_finilize_parallel_timeout()).await?;


All the wait_transactions calls receive check_finilize_parallel_timeout. Need to encapsulate that logic in the exec manager

Sumrachek · 2023-12-28T10:51:59Z

src/validator/collator.rs

-        // process newly-generated messages (only by including them into output queue)
-        self.process_new_messages(
-            true, prev_data, collator_data, &mut exec_manager).await?;
+        // DO NOT NEED THIS - all new messages were queued already


Just delete the commented code. Git remembers all the history =)

Sumrachek · 2023-12-28T13:05:09Z

src/validator/collator.rs

    }
 }

+type TxLastLt = u64;


Usually, we don't use type redefinitions.

Sumrachek · 2023-12-28T13:06:49Z

src/validator/collator.rs


+type TxLastLt = u64;
+
 struct CollatorData {


Encapsulation of the new parameters to some new struct might be a good idea.

Won't fix. Finally we should encapsulate and existing context parameters, too. Not in this PR

Sumrachek · 2023-12-28T13:34:16Z

src/validator/collator.rs

+                }
+            }
+        }
+        msgs_to_revert.reverse();


Consider using .iter().rev()

…ation

Sumrachek reviewed Dec 29, 2023

View reviewed changes

SmaGMan added 8 commits December 30, 2023 21:48

parallel collation limits by accounts

181eb38

cancel parallel collation on finalize timeout, commit account changes

bc05589

ability to revert transaction changes

c668635

improved processed new message revert, trxs waiting, parallel cancell…

2f37816

…ation

optimized out queue msg deletion and adding

1946ec3

fixed msg hash calculation

dfa3430

fixed deps and build

cd2feba

parallel collation refactoring

0440c96

SmaGMan force-pushed the feature/parallel-collation-p branch from b33a3b3 to 0440c96 Compare December 31, 2023 10:14


		let rand_seed = rand_seed.unwrap_or_else(\|\| secure_256_bits().into());

		let finalize_parallel_timeout_ms =

Conversation

SmaGMan commented Dec 23, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants