Skip to content

squads: add pre-entry checks #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crypta-Eve merged 1 commit into from
Feb 11, 2026
Merged

squads: add pre-entry checks #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Http/Controllers/Squads/ApplicationsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ public function show(Squad $squad, int $id)
*/
public function store(Request $request, Squad $squad)
{
if(!$squad->isUserEligible(auth()->user())) {
return redirect()->back()->with('error','You are not eligible for this squad!');
}

// in case the squad is manual and does not contain any moderator
// applications are self-approved.
if ($squad->type == 'manual' && $squad->moderators->isEmpty()) {
Expand Down Expand Up @@ -108,6 +112,10 @@ public function approve(Squad $squad, int $id)
{
$application = SquadApplication::with('squad', 'user')->find($id);

if(!$squad->isUserEligible($application->user)) {
return redirect()->back()->with('error','The applicant is not eligible for this squad!');
}

$squad->members()->save($application->user);

$message = sprintf('Approved application from %s into squad %s.',
Expand Down