feat(logging): Simplify passing options to the logging module#229
Merged
feat(logging): Simplify passing options to the logging module#229
Conversation
Rather than expecting people to type error prone fx value groups, we expose module options as a vararg in the module constructor. This gives application writers an easier way to tune the module. Other modules already use this pattern successfully. We also made the following subcomponent tuning: * We expose additional options on the fx system logger * We only show debug logs of the fx system logger in development mode * We never show debug logs of the grpc framework
aureliar8
approved these changes
Feb 27, 2026
olivas-bo
reviewed
Feb 27, 2026
|
|
||
| All logs emitted by the fx system itself are also logged via the zap Logger. In development mode | ||
| all events are logged at Debug level, errors are logged at Error level. | ||
| In preproduction and production mode only Error events are logged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than expecting people to type error prone fx value groups, we expose module options as a vararg in the module constructor.
This gives application writers an easier way to tune the module.
Other modules already use this pattern successfully.
We also made the following subcomponent tuning: