Improve parsing of empty nulls and lists of objects#18
Open
iteratee wants to merge 2 commits intoexosite:masterfrom
Open
Improve parsing of empty nulls and lists of objects#18iteratee wants to merge 2 commits intoexosite:masterfrom
iteratee wants to merge 2 commits intoexosite:masterfrom
Conversation
Use bounded lookahead to improve parsing of lists of objects and empty keys that should parse as null. Previously an empty key would parse as an object that contained keys that should have been siblings. Includes an expanded test of null parsing and a hie.yaml file that occurred in the wild and did not parse correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use lookahead to improve parsing of empty keys that should be parsed as null and lists consisting of items.
All current tests pass, and the null test has been expanded to include cases that would fail without this code.