Skip to content

Conversation

dhruvinjs
Copy link
Contributor

Description

Issue #2058

This is my first contribution to the project.  
I’ve corrected a typo in the Chinese routing guide where the routes `/random.text` and `/` were mislabeled.  

File updated:  
- `guide/routing.md` (Chinese version)

Please review and let me know if any improvements are needed.

Developer's Certificate of Origin

By making this contribution, I certify that:

- The work is my own or based on appropriately licensed work.  
- I have the right to submit it under the project’s open source license.  
- I agree that this contribution is public and may be redistributed under the same license.  

Signed-off-by: dhruvinjs <[email protected]>

@dhruvinjs dhruvinjs requested a review from a team as a code owner October 6, 2025 08:12
Copy link

netlify bot commented Oct 6, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 8d880f9
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/68e379dc2603270008ba87ce
😎 Deploy Preview https://deploy-preview-2077--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

github-actions bot commented Oct 6, 2025

🚦 Lighthouse Results (Mobile & Desktop)

URL Device Perf A11y Best Practices
/ mobile 🔴 45 🟢 100 🟢 96
/en/blog/posts.html mobile 🟠 76 🟢 96 🟢 96
/en/5x/api.html mobile 🔴 58 🟢 95 🟢 96
/ desktop 🟢 98 🟢 100 🟢 96
/en/blog/posts.html desktop 🟢 98 🟢 96 🟢 93
/en/5x/api.html desktop 🟢 100 🟢 95 🟢 96

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t speak Chinese, but I reviewed the diff and the changes make sense based on the code examples. Thanks for the fix @dhruvinjs! 👍

@UlisesGascon UlisesGascon self-assigned this Oct 6, 2025
@UlisesGascon UlisesGascon merged commit 3def603 into expressjs:gh-pages Oct 6, 2025
14 checks passed
@dhruvinjs
Copy link
Contributor Author

Hey @UlisesGascon , thanks for merging! Are there any other issues I could help with? I’m new to open source and eager to learn.

@UlisesGascon
Copy link
Member

@dhruvinjs I like your enthusiasm! Few ideas:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants