Skip to content

Conversation

kp-said-rehouni
Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni commented Oct 13, 2025

Description

This PR adds full Mac Catalyst support to Lightway Core, enabling iOS apps using the Lightway framework to run natively on macOS. The implementation includes build scripts and Xcode configuration for both Intel (x86_64) and Apple Silicon (arm64) Macs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All active GitHub checks are passing
  • The correct base branch is being used, if not main

Add build functions for Mac Catalyst with both x86_64 and arm64
architectures. The implementation includes:
  - build_maccatalyst_arm64(): Builds for Apple Silicon Macs
  - build_maccatalyst_x86_64(): Builds for Intel Macs
  - build_maccatalyst_universal_binary(): Creates universal binary
  - build_maccatalyst(): Orchestrates the complete build
@kp-said-rehouni kp-said-rehouni changed the title Mac catalyst support Add Mac Catalyst Support to Lightway Core Oct 13, 2025
@kp-said-rehouni kp-said-rehouni force-pushed the mac_catalyst_support branch 9 times, most recently from 208227b to 1e81d20 Compare October 14, 2025 16:00
@kp-said-rehouni kp-said-rehouni marked this pull request as ready for review October 15, 2025 07:04
@kp-said-rehouni kp-said-rehouni requested a review from a team as a code owner October 15, 2025 07:04
Comment on lines 265 to 266
cd third_party/wolfssl
PREFIX=$(pwd)/../builds/wolfssl_ios ./autotools-ios-helper.sh -maccatalyst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? I thought ios.yml would have called autotools-ios-helper.sh already

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. This is needed to compile wolfssl for catalyst so we can generate the Lightway framework with catalyst compatibility in the next steps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in this task you're targeting ios, why would it need maccatalyst wolfssl?

If xcframework needs it, why doesn't it also need maccatalyst libhelium?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the xcframework use the helium source code instead of the static library? I'm a bit confused.
But anyways I think you are right, since the output is the static library. Will remove this.
Thank you!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated it @xv-thomas-leong

This commit adds catalyst.yml build configuration to build helium
and wolfSSL for Mac Catalyst.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants