-
Notifications
You must be signed in to change notification settings - Fork 67
Add Mac Catalyst Support to Lightway Core #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add build functions for Mac Catalyst with both x86_64 and arm64 architectures. The implementation includes: - build_maccatalyst_arm64(): Builds for Apple Silicon Macs - build_maccatalyst_x86_64(): Builds for Intel Macs - build_maccatalyst_universal_binary(): Creates universal binary - build_maccatalyst(): Orchestrates the complete build
208227b
to
1e81d20
Compare
.github/workflows/ci.yml
Outdated
cd third_party/wolfssl | ||
PREFIX=$(pwd)/../builds/wolfssl_ios ./autotools-ios-helper.sh -maccatalyst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? I thought ios.yml
would have called autotools-ios-helper.sh
already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. This is needed to compile wolfssl for catalyst so we can generate the Lightway framework with catalyst compatibility in the next steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in this task you're targeting ios, why would it need maccatalyst wolfssl?
If xcframework needs it, why doesn't it also need maccatalyst libhelium?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't the xcframework use the helium source code instead of the static library? I'm a bit confused.
But anyways I think you are right, since the output is the static library. Will remove this.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated it @xv-thomas-leong
This commit adds catalyst.yml build configuration to build helium and wolfSSL for Mac Catalyst.
1e81d20
to
96e7682
Compare
Description
This PR adds full Mac Catalyst support to Lightway Core, enabling iOS apps using the Lightway framework to run natively on macOS. The implementation includes build scripts and Xcode configuration for both Intel (x86_64) and Apple Silicon (arm64) Macs.
Types of changes
Checklist:
main