Skip to content

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented May 26, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Simplifies the code

Test Plan

Relying on existing tests

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

I noticed this while working on #11042. That PR is failing the CI for reasons that seem totally unrelated to it. I can't figure out what's going on there, so thought I'd break this off separately to see if it can pass independent of those changes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 26, 2025
Copy link

netlify bot commented May 26, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 6a41a67
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6833e3b21e99740008ad3c0c
😎 Deploy Preview https://deploy-preview-11196--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented May 26, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 42 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🔴 48 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 71 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 55 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 45 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 61 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@benmccann benmccann force-pushed the simplify-swizzle-glob branch 5 times, most recently from e76bab6 to 7cbb71c Compare May 26, 2025 03:38
@benmccann benmccann force-pushed the simplify-swizzle-glob branch from 7cbb71c to 6a41a67 Compare May 26, 2025 03:44
@slorber slorber added the pr: ignore This PR is not meaningful enough to appear in the changelog. label May 26, 2025
@slorber
Copy link
Collaborator

slorber commented May 26, 2025

Thanks

@slorber slorber merged commit ba18a8b into facebook:main May 26, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants