Skip to content

Conversation

@immadhavv
Copy link
Contributor

@immadhavv immadhavv commented Oct 3, 2025

Description

Added unit test coverage for certain critical files as listed here - https://docs.google.com/document/d/1ixmcUXlFC_-7bg4IUVM9WYlh2Vu8S0hBn0m21axWscg/edit?usp=sharing

Earlier the unit test coverage was for all the flows irrespectively. This addition validates the most critical files in the system and the unit test coverage for the same.

Currently the coverage for these flows is at 5% and we should aim to bring this up to a reasonably higher value soon.

Type of change

Please delete options that are not relevant

  • Add (non-breaking change which adds functionality)

Checklist

  • [✅] I have commented my code, particularly in hard-to-understand areas, if any.
  • [✅] I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • [✅] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
  • [✅] I followed general Pull Request best practices. Meta employees to follow this wiki.
  • [✅] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • [] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
  • [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

Changelog entry

added unit test coverage for critical flows

Test Plan

Github workflow for PHP unit tests go through as expected .

Screenshots

Before

NA

After

https://github.com/immadhavv/facebook-for-woocommerce/actions/runs/18521736750/job/52782988289

@meta-cla meta-cla bot added the CLA Signed label Oct 3, 2025
@immadhavv immadhavv added the changelog: add A new feature, function, or functionality was added. label Oct 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

📦 Latest Plugin Build

Built at: 2025-10-21T16:12:51.678Z
Commit: e7e0496
Size: 1.4M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

@meta-codesync
Copy link

meta-codesync bot commented Oct 3, 2025

@immadhavv has imported this pull request. If you are a Meta employee, you can view this in D83846717.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: add A new feature, function, or functionality was added. CLA Signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants