Open
Conversation
16afb25 to
62ab2f8
Compare
a4afe92 to
8d1fafb
Compare
Contributor
Author
|
I've updated the PR with the latest changes from |
5cb5ee8 to
66a1817
Compare
66a1817 to
fa49a0c
Compare
Contributor
Author
|
The PR has been updated with the latest changes from |
9afc477 to
27424fd
Compare
Closed
d1f8be5 to
4137058
Compare
3798ff6 to
a193710
Compare
b65d7bf to
ae23fcb
Compare
6278969 to
f57f8a8
Compare
e3a272e to
1a0cc84
Compare
Contributor
Author
|
@zielinskimz any chance to have a look at these PRs? |
77f308b to
f4a2557
Compare
Contributor
Author
|
@zielinskimz I've updated the PR to include the latest changes from |
f4a2557 to
9f50876
Compare
saifulrizal
reviewed
Nov 15, 2025
saifulrizal
left a comment
There was a problem hiding this comment.
We are pleased to offer you the opportunity to compose a review. Your insights are greatly valued and will help others make informed decisions. Please take your time to share your experience. We appreciate your contribution to our community. Thank you for your willingness to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apache HTTP classes have been removed from the Android SDK in Android 6.0. Developers needing these classes can add
useLibrary 'org.apache.http.legacy'to their Gradle file to keep using that library.Robolectric now provides shadows for this library in a separate module (
org.robolectric:shadows-httpclient), so it is no longer part of the main module.Changelog
Remove dependency on Apache HTTP.
Test Plan
As per CONTRIBUTING.md, I've ran
./gradlew test, but the task fails with the following message:Note that I have the same result from
master.