fix auto complete dict key when possible #1189 #1515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinto0
reviewed
Nov 6, 2025
kinto0
reviewed
Nov 7, 2025
kinto0
approved these changes
Nov 10, 2025
kinto0
requested changes
Nov 11, 2025
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
sorry, let's split this PR into two:
- lsp changes
- typing changes
Co-authored-by: Kyle Into <[email protected]>
Co-authored-by: Kyle Into <[email protected]>
Co-authored-by: Kyle Into <[email protected]>
Co-authored-by: Kyle Into <[email protected]>
asukaminato0721
force-pushed
the
1189
branch
from
682e528 to
bf00dd4
Compare
asukaminato0721
force-pushed
the
1189
branch
from
1bf7240 to
a4bbbc0
Compare
Contributor
Author
|
asukaminato0721
commented
Nov 22, 2025
stroxler
approved these changes
Nov 24, 2025
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1189
Introduced dict key completions: added facet chains and literal facet propagation.