fix: ensure await check recurses into generator conditions #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic failed to detect 'await' when nested inside comparisons (e.g., 'if await foo() == True'). This implements an iterative DFS traversal to correctly scan the entire expression tree, including the root and nested children. Fixes facebook#1611
Contributor
|
Importing the PR failed, it looks like there's probably a rebase conflict - would you mind rebasing on |
Contributor
|
Oh never mind, I think a separate PR from @AryanBagade already landed with basically the same fix. Closing since we can't really merge these, but thanks for the PR, it's the right fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1611.
Previously, comprehensions were incorrectly inferred as synchronous
Generatorinstead ofAsyncGeneratorwhen theawaitkeyword was nested inside a binary expression or comparison (e.g.,if await foo() == True). The previous AST visitor did not fully recurse into the condition's children in all cases.The Fix
I updated the
contains_awaitlogic inast.rsto use a manual iterative Depth-First Search (DFS) using a stack.awaitnodes even when deeply nested inside other expressions.Test Plan
Added a regression test
test_async_generator_nested_await_in_conditioninyields.rs.Verification:
if await foo() == Truecorrectly results inAsyncGenerator.cargo test -p pyrefly --lib test_async_generator_nested_await_in_condition(Passed)