Default to including all devDependencies in the Electron build #53800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds `prune: false` to the `electron/packager`-based build script for the DevTools standalone shell. This would have stopped D82236159 from causing a regression. We may want to iterate further on a mechanism for keeping the following sets of dependencies separate in `react-native/debugger-shell`: 1. Build-time, Electron-only dependencies (currently in `devDependencies`) 2. Test-only dependencies (currently also in `devDependencies`) 3. Node dependencies (currently in `dependencies`) Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D82538084
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Facebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
prune: falseto theelectron/packager-based build script for the DevTools standalone shell. This would have stopped D82236159 from causing a regression. We may want to iterate further on a mechanism for keeping the following sets of dependencies separate inreact-native/debugger-shell:devDependencies)devDependencies)dependencies)Changelog: [Internal]
Reviewed By: vzaidman
Differential Revision: D82538084