Skip to content

Conversation

vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Sep 18, 2025

Summary:
iOS has a colorful "Refreshing..." banner:
image

While android doesn't respect the color HMR asks it to set up for the banner:
image

Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS

Differential Revision: D82726743

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 18, 2025
@facebook-github-bot
Copy link
Contributor

@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating diff in D82726743.

Summary:
Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS

iOS has a colorful "Refreshing..." banner:
 {F1982086204} 

While android doesn't respect the color HMR asks it to set up for the banner:
 {F1982086218}

Differential Revision: D82726743
@facebook-github-bot
Copy link
Contributor

@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating diff in D82726743.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

vzaidman added a commit to vzaidman/react-native that referenced this pull request Sep 22, 2025
…ook#53846)

Summary:

Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS

iOS has a colorful "Refreshing..." banner:
 {F1982086204} 

While android doesn't respect the color HMR asks it to set up for the banner:
 {F1982086218}

Reviewed By: cortinico

Differential Revision: D82726743
vzaidman added a commit to vzaidman/react-native that referenced this pull request Sep 22, 2025
…ook#53846)

Summary:

Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS

iOS has a colorful "Refreshing..." banner:
 {F1982086204} 

While android doesn't respect the color HMR asks it to set up for the banner:
 {F1982086218}

Reviewed By: cortinico

Differential Revision: D82726743
vzaidman added a commit to vzaidman/react-native that referenced this pull request Sep 22, 2025
…ook#53846)

Summary:

Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS

iOS has a colorful "Refreshing..." banner:
 {F1982086204} 

While android doesn't respect the color HMR asks it to set up for the banner:
 {F1982086218}

Reviewed By: cortinico

Differential Revision: D82726743
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @vzaidman in 4d45e59

When will my fix make it into a release? | How to file a pick request?

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 22, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4d45e59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants