-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Align Android with iOS in displaying HMR "refreshing" in color #53846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS
iOS has a colorful "Refreshing..." banner:
{F1982086204}
While android doesn't respect the color HMR asks it to set up for the banner:
{F1982086218}
Differential Revision: D82726743
3dc6691 to
fa0115b
Compare
cortinico
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Sep 22, 2025
…ook#53846) Summary: Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS iOS has a colorful "Refreshing..." banner: {F1982086204} While android doesn't respect the color HMR asks it to set up for the banner: {F1982086218} Reviewed By: cortinico Differential Revision: D82726743
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Sep 22, 2025
…ook#53846) Summary: Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS iOS has a colorful "Refreshing..." banner: {F1982086204} While android doesn't respect the color HMR asks it to set up for the banner: {F1982086218} Reviewed By: cortinico Differential Revision: D82726743
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Sep 22, 2025
…ook#53846) Summary: Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS iOS has a colorful "Refreshing..." banner: {F1982086204} While android doesn't respect the color HMR asks it to set up for the banner: {F1982086218} Reviewed By: cortinico Differential Revision: D82726743
|
This pull request was successfully merged by @vzaidman in 4d45e59 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 4d45e59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
meta-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:

iOS has a colorful "Refreshing..." banner:
While android doesn't respect the color HMR asks it to set up for the banner:

Changelog: [Android][Added] - hot reload banner is now displayed in blue background like on iOS
Differential Revision: D82726743