Remove jest from "types" in @react-native/typescript-config
#53855
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This is the right move in principle but I think it should be labelled semver breaking - if users update to this without making the required change, their projects won't typecheck IIUC (which could break their CI, etc). @cortinico where do we stand on that at the moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See #53563 for more context.
Drafted to wait for react-native-community/template#177 to merge and release.
Changelog:
[GENERAL] [REMOVED] - Remove explicit use of jest types in tsconfig.json: Apps should declare this themselves.
Test Plan:
npx @react-native-community/cli@latest init TestApp(once Add explicit use ofjesttypes intsconfig.jsonreact-native-community/template#177 is merged and released)node_modules/@react-native/typescript-config/tsconfig.jsonwith this suggested change.