Fix incorrect validation of feature flags in DefaultNewArchitectureEntryPoint.loadWithFeatureFlags() method #53863
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tryPoint.loadWithFeatureFlags() method Summary: In this diff I'm fixing an incorrect validation of feature flags in DefaultNewArchitectureEntryPoint.loadWithFeatureFlags() method. changelog: [internal] internal Differential Revision: D82841006
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
fb-exported
p: Facebook
cortinico
approved these changes
Sep 22, 2025
|
This pull request has been merged in 23b2b99. |
|
This pull request was successfully merged by @mdvacca in 23b2b99 When will my fix make it into a release? | How to file a pick request? |
cortinico
pushed a commit
that referenced
this pull request
Sep 22, 2025
…tryPoint.loadWithFeatureFlags() method (#53863) Summary: Pull Request resolved: #53863 In this diff I'm fixing an incorrect validation of feature flags in DefaultNewArchitectureEntryPoint.loadWithFeatureFlags() method. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D82841006 fbshipit-source-id: 6f50f2475255d7b841d9224bc8808119dcc68aec
|
This pull request was successfully merged by @mdvacca in ea2d95a When will my fix make it into a release? | How to file a pick request? |
vzaidman
pushed a commit
that referenced
this pull request
Sep 22, 2025
* Ensure legacy architecture can't be initialized in Android (#53806) Summary: Pull Request resolved: #53806 The Legacy architecture of React Native is not supported anymore, let's ensure nobody can initialize it anymore changelog: [internal] internal Reviewed By: cortinico Differential Revision: D82465004 fbshipit-source-id: 099764fb59d906b11cf6ad0cc6208f56df029d19 * Runtime check that NewArchitecture is enabled in DefaultNewArchitectureEntryPoint (#53780) Summary: Pull Request resolved: #53780 This is a commit we're going to pick in 0.82 as we want to make sure users cannot invoke `load()` from `DefaultNewArchitectureEntryPoint` with flags that are not true,true,true. Changelog: [Android] [Changed] - Runtime check that NewArchitecture is enabled in DefaultNewArchitectureEntryPoint Reviewed By: mdvacca Differential Revision: D82456975 fbshipit-source-id: 749996a3491913cfe400173608218077c3ffbc10 * Fix DefaultNewArchitectureEntryPoint config validation (#53807) Summary: Pull Request resolved: #53807 We need to read the values off feature flags before checking them. ## Changelog [Internal] Reviewed By: javache Differential Revision: D82572898 fbshipit-source-id: 09fbc09570c78b41d9c25fb03c5557e390da7cae * Fix incorrect validation of feature flags in DefaultNewArchitectureEntryPoint.loadWithFeatureFlags() method (#53863) Summary: Pull Request resolved: #53863 In this diff I'm fixing an incorrect validation of feature flags in DefaultNewArchitectureEntryPoint.loadWithFeatureFlags() method. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D82841006 fbshipit-source-id: 6f50f2475255d7b841d9224bc8808119dcc68aec --------- Co-authored-by: David Vacca <[email protected]> Co-authored-by: Eric Rozell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff I'm fixing an incorrect validation of feature flags in DefaultNewArchitectureEntryPoint.loadWithFeatureFlags() method.
changelog: [internal] internal
Differential Revision: D82841006