Fix ImageProps default values #54545
Closed
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87083023. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 14, 2025
Summary: Changelog: [Internal] Currently these default values https://reactnative.dev/docs/image#resizemethod-android https://reactnative.dev/docs/image#resizemultiplier-android are not correctly treated in C++ code as parsing bails out here: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177 By setting default values in the struct, we can fix it Differential Revision: D87083023
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 14, 2025
Summary: Changelog: [Internal] Currently these default values https://reactnative.dev/docs/image#resizemethod-android https://reactnative.dev/docs/image#resizemultiplier-android are not correctly treated in C++ code as parsing bails out here: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177 By setting default values in the struct, we can fix it Differential Revision: D87083023
christophpurrer
force-pushed
the
export-D87083023
branch
from
50c0631 to
865ff09
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 14, 2025
Summary: Changelog: [Internal] Currently these default values https://reactnative.dev/docs/image#resizemethod-android https://reactnative.dev/docs/image#resizemultiplier-android are not correctly treated in C++ code as parsing bails out here: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177 By setting default values in the struct, we can fix it Differential Revision: D87083023
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 14, 2025
Summary: Changelog: [Internal] Currently these default values https://reactnative.dev/docs/image#resizemethod-android https://reactnative.dev/docs/image#resizemultiplier-android are not correctly treated in C++ code as parsing bails out here: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177 By setting default values in the struct, we can fix it Differential Revision: D87083023
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 14, 2025
Summary: Changelog: [Internal] Currently these default values https://reactnative.dev/docs/image#resizemethod-android https://reactnative.dev/docs/image#resizemultiplier-android are not correctly treated in C++ code as parsing bails out here: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177 By setting default values in the struct, we can fix it Reviewed By: sbuggay Differential Revision: D87083023
christophpurrer
force-pushed
the
export-D87083023
branch
from
865ff09 to
3f34854
Compare
Summary: Changelog: [Internal] Currently these default values https://reactnative.dev/docs/image#resizemethod-android https://reactnative.dev/docs/image#resizemultiplier-android are not correctly treated in C++ code as parsing bails out here: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177 By setting default values in the struct, we can fix it Reviewed By: sbuggay Differential Revision: D87083023
christophpurrer
force-pushed
the
export-D87083023
branch
from
3f34854 to
51db60b
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 15, 2025
Summary: Changelog: [Internal] Currently these default values https://reactnative.dev/docs/image#resizemethod-android https://reactnative.dev/docs/image#resizemultiplier-android are not correctly treated in C++ code as parsing bails out here: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177 By setting default values in the struct, we can fix it Reviewed By: sbuggay Differential Revision: D87083023
Collaborator
|
This pull request was successfully merged by @christophpurrer in 376183e When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 376183e. |
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Nov 15, 2025
Summary: Pull Request resolved: facebook/react-native#54545 Changelog: [Internal] Currently these default values https://reactnative.dev/docs/image#resizemethod-android https://reactnative.dev/docs/image#resizemultiplier-android are not correctly treated in C++ code as parsing bails out here: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177 By setting default values in the struct, we can fix it Reviewed By: sbuggay Differential Revision: D87083023 fbshipit-source-id: b8e16d0f6732392bafee01848c1c516e91ab806b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Currently these default values
https://reactnative.dev/docs/image#resizemethod-android
https://reactnative.dev/docs/image#resizemultiplier-android
are not correctly treated in C++ code as parsing bails out here:
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177
By setting default values in the struct, we can fix it
Differential Revision: D87083023