Generate RouterInfoFwd.h forward-declaration headers#481
Open
alikhtarov wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Generate RouterInfoFwd.h forward-declaration headers#481alikhtarov wants to merge 1 commit intofacebookresearch:v2-betafrom
alikhtarov wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@alikhtarov has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94251624. |
alikhtarov
pushed a commit
to alikhtarov/DCPerf
that referenced
this pull request
Feb 26, 2026
…h#481) Summary: Update the carbon compiler to generate lightweight `RouterInfoFwd.h` headers alongside the existing `RouterInfo.h` for each service. These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct. This improves build speed as some includes only need the request list, not the whole RouterInfo. Claude spec P2203329673 plan P2203333653 Reviewed By: stuclar Differential Revision: D94251624
alikhtarov
force-pushed
the
export-D94251624-to-v2-beta
branch
from
a0f419c to
eb2a48b
Compare
alikhtarov
pushed a commit
to alikhtarov/DCPerf
that referenced
this pull request
Feb 26, 2026
…h#481) Summary: Pull Request resolved: facebookresearch#481 Update the carbon compiler to generate lightweight `RouterInfoFwd.h` headers alongside the existing `RouterInfo.h` for each service. These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct. This improves build speed as some includes only need the request list, not the whole RouterInfo. Claude spec P2203329673 plan P2203333653 Reviewed By: stuclar Differential Revision: D94251624
alikhtarov
force-pushed
the
export-D94251624-to-v2-beta
branch
from
eb2a48b to
478b07c
Compare
alikhtarov
pushed a commit
to alikhtarov/DCPerf
that referenced
this pull request
Feb 27, 2026
…h#481) Summary: Update the carbon compiler to generate lightweight `RouterInfoFwd.h` headers alongside the existing `RouterInfo.h` for each service. These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct. This improves build speed as some includes only need the request list, not the whole RouterInfo. Claude spec P2203329673 plan P2203333653 Reviewed By: stuclar Differential Revision: D94251624
alikhtarov
force-pushed
the
export-D94251624-to-v2-beta
branch
from
478b07c to
4340d6d
Compare
alikhtarov
pushed a commit
to alikhtarov/DCPerf
that referenced
this pull request
Feb 27, 2026
…h#481) Summary: Pull Request resolved: facebookresearch#481 Update the carbon compiler to generate lightweight `RouterInfoFwd.h` headers alongside the existing `RouterInfo.h` for each service. These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct. This improves build speed as some includes only need the request list, not the whole RouterInfo. Claude spec P2203329673 plan P2203333653 Reviewed By: stuclar Differential Revision: D94251624
alikhtarov
force-pushed
the
export-D94251624-to-v2-beta
branch
from
4340d6d to
44771dc
Compare
alikhtarov
pushed a commit
to alikhtarov/DCPerf
that referenced
this pull request
Feb 27, 2026
…h#481) Summary: Update the carbon compiler to generate lightweight `RouterInfoFwd.h` headers alongside the existing `RouterInfo.h` for each service. These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct. This improves build speed as some includes only need the request list, not the whole RouterInfo. Claude spec P2203329673 plan P2203333653 Reviewed By: stuclar Differential Revision: D94251624
alikhtarov
force-pushed
the
export-D94251624-to-v2-beta
branch
from
44771dc to
2cb726f
Compare
…h#481) Summary: Pull Request resolved: facebookresearch#481 Update the carbon compiler to generate lightweight `RouterInfoFwd.h` headers alongside the existing `RouterInfo.h` for each service. These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct. This improves build speed as some includes only need the request list, not the whole RouterInfo. Claude spec P2203329673 plan P2203333653 Reviewed By: stuclar Differential Revision: D94251624
alikhtarov
force-pushed
the
export-D94251624-to-v2-beta
branch
from
2cb726f to
9e1392b
Compare
meta-codesync bot
pushed a commit
to facebook/mcrouter
that referenced
this pull request
Mar 2, 2026
Summary: X-link: facebookresearch/DCPerf#481 Update the carbon compiler to generate lightweight `RouterInfoFwd.h` headers alongside the existing `RouterInfo.h` for each service. These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct. This improves build speed as some includes only need the request list, not the whole RouterInfo. Claude spec P2203329673 plan P2203333653 Reviewed By: stuclar Differential Revision: D94251624 fbshipit-source-id: c1602709dcf7673488afc2eab395116c9b7a973f
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 2, 2026
Summary: Pull Request resolved: #481 Update the carbon compiler to generate lightweight `RouterInfoFwd.h` headers alongside the existing `RouterInfo.h` for each service. These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct. This improves build speed as some includes only need the request list, not the whole RouterInfo. Claude spec P2203329673 plan P2203333653 Reviewed By: stuclar Differential Revision: D94251624 fbshipit-source-id: c1602709dcf7673488afc2eab395116c9b7a973f
meta-codesync bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 2, 2026
Summary: X-link: facebookresearch/DCPerf#481 Update the carbon compiler to generate lightweight `RouterInfoFwd.h` headers alongside the existing `RouterInfo.h` for each service. These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct. This improves build speed as some includes only need the request list, not the whole RouterInfo. Claude spec P2203329673 plan P2203333653 Reviewed By: stuclar Differential Revision: D94251624 fbshipit-source-id: c1602709dcf7673488afc2eab395116c9b7a973f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Update the carbon compiler to generate lightweight
RouterInfoFwd.hheadersalongside the existing
RouterInfo.hfor each service.These only contain forward declaration for the requests/replies, the lists RoutableRequests, RoutableReplies, AllRequests, and a forward declaration of the RouterInfo struct.
This improves build speed as some includes only need the request list, not the whole RouterInfo.
Claude spec P2203329673 plan P2203333653
Reviewed By: stuclar
Differential Revision: D94251624