Open
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37490665 |
wenhaizhu
pushed a commit
to wenhaizhu/fbpcf
that referenced
this pull request
Jun 29, 2022
Summary: Pull Request resolved: facebookresearch#249 Diff for supporting multipart upload in GCP. Interesting that GCP Client Libarary doesn't support multipart upload (source: https://cloud.google.com/storage/docs/uploads-downloads#support_per_tool). There is a comment in stackoverflower (https://stackoverflow.com/a/71698884) mentioned that "You can do Multipart upload to GCS using the S3 library, as the GCS XML API is compatible with this. There is a guide to using the S3 library with GCS here. " So I'm following it here. Differential Revision: D37490665 fbshipit-source-id: fd23d17eaf02fb4d67d93c818f77eef17e868505
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37490665 |
wenhaizhu
force-pushed
the
export-D37490665
branch
from
63f9ed3 to
2a52574
Compare
wenhaizhu
pushed a commit
to wenhaizhu/fbpcf
that referenced
this pull request
Jun 30, 2022
Summary: Pull Request resolved: facebookresearch#249 Diff for supporting multipart upload in GCP. Interesting that GCP Client Libarary doesn't support multipart upload (source: https://cloud.google.com/storage/docs/uploads-downloads#support_per_tool). There is a comment in stackoverflower (https://stackoverflow.com/a/71698884) mentioned that "You can do Multipart upload to GCS using the S3 library, as the GCS XML API is compatible with this. There is a guide to using the S3 library with GCS here. " So I'm following it here. Differential Revision: D37490665 fbshipit-source-id: fdebc1be6dd85822b382c9f96454abebf5d470f2
wenhaizhu
force-pushed
the
export-D37490665
branch
from
2a52574 to
db85bad
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37490665 |
Summary: Pull Request resolved: facebookresearch#249 Diff for supporting multipart upload in GCP. Interesting that GCP Client Libarary doesn't support multipart upload (source: https://cloud.google.com/storage/docs/uploads-downloads#support_per_tool). There is a comment in stackoverflower (https://stackoverflow.com/a/71698884) mentioned that "You can do Multipart upload to GCS using the S3 library, as the GCS XML API is compatible with this. There is a guide to using the S3 library with GCS here. " So I'm following it here. Differential Revision: D37490665 fbshipit-source-id: 032b1b0f073a126b56764ed46deb497a4a4dd453
wenhaizhu
force-pushed
the
export-D37490665
branch
from
db85bad to
3f25022
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37490665 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Diff for supporting multipart upload in GCP.
Interesting that GCP Client Libarary doesn't support multipart upload (source: https://cloud.google.com/storage/docs/uploads-downloads#support_per_tool). There is a comment in stackoverflower (https://stackoverflow.com/a/71698884) mentioned that "You can do Multipart upload to GCS using the S3 library, as the GCS XML API is compatible with this. There is a guide to using the S3 library with GCS here. " So I'm following it here.
Differential Revision: D37490665