Fix -Wbitwise-instead-of-logical in 5 files starting w/ fbpcs/emp_games/pcf2_attribution/AttributionRule_impl.h#462
Open
r-barnes wants to merge 1 commit intofacebookresearch:mainfrom
Open
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42347735 |
…es/pcf2_attribution/AttributionRule_impl.h (#9310) Summary: X-link: facebook/hhvm#9310 X-link: facebookincubator/dynolog#89 Pull Request resolved: facebookresearch#462 X-link: facebookresearch/fbpcs#2016 With LLVM-15, `&&` and `||` are required for boolean operands, rather than `&` and `|` which can be confused for bitwise operations. Fixing such ambiguity helps makes our code more readable. - If you approve of this diff, please use the "Accept & Ship" button :-) Differential Revision: D42347735 fbshipit-source-id: 44d51851a630d42e8bf9f6a72949399264384e8e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42347735 |
r-barnes
force-pushed
the
export-D42347735
branch
from
043be87 to
c5a19ef
Compare
r-barnes
added a commit
to r-barnes/hhvm
that referenced
this pull request
Jan 7, 2023
…es/pcf2_attribution/AttributionRule_impl.h (facebook#9310) Summary: Pull Request resolved: facebook#9310 X-link: facebookincubator/dynolog#89 X-link: facebookresearch/fbpcf#462 X-link: facebookresearch/fbpcs#2016 With LLVM-15, `&&` and `||` are required for boolean operands, rather than `&` and `|` which can be confused for bitwise operations. Fixing such ambiguity helps makes our code more readable. - If you approve of this diff, please use the "Accept & Ship" button :-) Differential Revision: D42347735 fbshipit-source-id: 3ec9c8af880cfce6490787662a4c3bc28f990bc7
r-barnes
added a commit
to r-barnes/fbpcs
that referenced
this pull request
Jan 7, 2023
…es/pcf2_attribution/AttributionRule_impl.h (#9310) Summary: X-link: facebook/hhvm#9310 X-link: facebookincubator/dynolog#89 X-link: facebookresearch/fbpcf#462 Pull Request resolved: facebookresearch#2016 With LLVM-15, `&&` and `||` are required for boolean operands, rather than `&` and `|` which can be confused for bitwise operations. Fixing such ambiguity helps makes our code more readable. - If you approve of this diff, please use the "Accept & Ship" button :-) Differential Revision: D42347735 fbshipit-source-id: 6e377b3c27cc1fe341e3dfd7d1b4a0adbf236889
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With LLVM-15,
&&and||are required for boolean operands, rather than&and|which can be confused for bitwise operations. Fixing such ambiguity helps makes our code more readable.Reviewed By: meyering
Differential Revision: D42347735