Skip to content

Fix wrong message types when calling PDU.toBuffer method #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix wrong message types when calling PDU.toBuffer method #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cec61c6
Update lib/defs.js types.cstring
0LEG0 Oct 5, 2021
6d362cf
Merge branch 'farhadi:master' into master
0LEG0 Oct 19, 2021
1fa6dd8
Merge branch 'farhadi:master' into master
0LEG0 Apr 20, 2022
cbe6052
Merge branch 'farhadi:master' into master
0LEG0 Jun 28, 2022
11bd6a2
Fix wrong message types when calling PDU.toBuffer method
0LEG0 Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/defs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ filters.message = {
if (Buffer.isBuffer(value)) {
return value;
}
var message = typeof value === 'string' ? value : value.message;
var message = typeof value === 'string' ? value : (typeof value === 'object' ? value.message : String(value));
if (typeof message === 'string' && message) {
var encoded = false;
if (value.udh) {
Expand Down
6 changes: 6 additions & 0 deletions test/filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,18 @@ describe('message GSM', function() {
data_coding: 0
};
var value = 'This is a Test';
var value0 = true;
var value1 = 3.145;
var value2 = {message: value};
var value3 = {message: Buffer.from(value)};
var encoded = Buffer.from(value);
var encoded0 = Buffer.from(String(value0));
var encoded1 = Buffer.from(String(value1));
describe('#encode()', function() {
it('should encode a high-level formatted short message to a low-level buffer', function() {
assert.deepEqual(filters.message.encode.call(pdu, value), encoded);
assert.deepEqual(filters.message.encode.call(pdu, value0), encoded0);
assert.deepEqual(filters.message.encode.call(pdu, value1), encoded1);
assert.deepEqual(filters.message.encode.call(pdu, value2), encoded);
assert.deepEqual(filters.message.encode.call(pdu, value3), encoded);
});
Expand Down