feat: track remote parent spans for OpenTelemetry compliance #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
julius/slsstmntvwuy
branch
from
c1b3f5f to
519deb3
Compare
1 task
|
Thank you very much! This update is awesome! I agree that we could wait a little bit for opentelemetry-tracing to get updated first. |
Cool. I'll just use my branch and set notifications when we get a new fastrace release. |
pimeys
added a commit
to grafbase/nexus
that referenced
this pull request
Sep 29, 2025
We want to update to otel 0.31, so we use a fork of fastrace crates until the pull request I opened there is merged: fast/fastrace#134
pimeys
added a commit
to grafbase/nexus
that referenced
this pull request
Sep 29, 2025
We want to update to otel 0.31, so we use a fork of fastrace crates until the pull request I opened there is merged: fast/fastrace#134
pimeys
force-pushed
the
julius/slsstmntvwuy
branch
from
e8265cd to
7885d41
Compare
|
@andylokandy tracing-opentelemetry 0.32.0 is now out and this pull request is ready to merge. |
- Updates opentelemetry crates to 0.31.0. - Add is_remote flag to identify spans with parents from remote services via trace context headers.
pimeys
force-pushed
the
julius/slsstmntvwuy
branch
from
7885d41 to
ccf450a
Compare
tisonkun
approved these changes
Oct 6, 2025
|
Thanks for your contribution @pimeys! LGTM. @andylokandy shall we merge this patch and cut a release for both fastrace and fastrace-opentelemetry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, it's that time again when renovate sends the update PR for opentelemetry crates, and the whole ecosystem needs to adapt and update. Let me help a bit with this PR:
Note: the benchmarks depend on tracing-opentelemetry, which has an open pull request for otel 0.31.0 updates. I'm using the dependency from git in here so I could validate the bench works and compiles. We might need to wait until we get a new version of tracing-opentelemetry before merging.