Skip to content

Conversation

asmh1989
Copy link

add chrono support #154

@tisonkun
Copy link
Contributor

What layout or appender do you use now?

I'm considering, instead of mergeing this polyfill patch, started to factor out the core APIs and concrete impls. So that you can depend on the API and exact impls as you wish. When you don't like the impls that depends on jiff, you can write your own, or copy the code and replace the jiff deps. Then you can still use the other APIs/components that doesn't depend on jiff.

@asmh1989
Copy link
Author

我现在是用到了 append-rolling-file, 您考虑的更多吧, 我这样改, 能最快满足我个人的需求, 还有还是希望开箱即用吧, 能features搞定的不要写代码

@tisonkun
Copy link
Contributor

嗯,我可能需要多点时间想想。这样改就 OK 的话,你可以考虑用 cargo patch 的能力切到你的分支上:

开箱即用的话,看看我九月份能不能有时间把模块拆分和 rolling file appender 另外几个 issue 一并看下。如果拆分完了,单独做一个依赖 chrono 的 crate 我看看合不合理。主要还是 chrono 和 jiff 的接口本来出入就比较大,强行缝合在一起,你说再来一个人说还要支持 time,合理不合理呢(x)

把这个事情缝合好本身都可以做一个通用的 datetime 抽象,对接不同的实现了😇

@asmh1989
Copy link
Author

好, 那我先用自己分支, 后续实现了记得通知下我

@tisonkun
Copy link
Contributor

Closed as won't fix, at least for now. See #169 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants