🐛 Fix parse_cors function to be consistent for both empty string and empty list
#1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone who is a maintainer, could you please add a label to this PR? Thanks. |
alejsdev
changed the title
YuriiMotov
reviewed
Sep 3, 2025
…ided after or between commas
rolkotaki
force-pushed
the
bugfix/parse-cors-function
branch
from
849cf1f to
e90d3a2
Compare
YuriiMotov
changed the title
parse_cors function to be consistent for both empty string and empty list
jpizquierdo
pushed a commit
to jpizquierdo/full-stack-fastapi-template
that referenced
this pull request
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
parse_corsfunction inconfig.pyso that it behaves consistently for both empty string and empty list.Currently, when an empty list is provided as an argument, it returns an empty list (
[]). However, when an empty string ("") is provided, it returns a list with an empty string ([""]) and starting the FastAPI application fails.