Skip to content

Conversation

@simone-sanfratello
Copy link
Contributor

@simone-sanfratello simone-sanfratello commented Nov 20, 2025

  • update deps
  • removed got in tests in favor of native fetch
  • removed @jsumners/line-reporter as in case of failures it's not possible to see output

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not directly use fetch? I would prefer removing that helper fn

@kibertoad
Copy link
Member

@Uzlopak wouldn't that require more boilerplate in every test?

@Uzlopak
Copy link
Contributor

Uzlopak commented Nov 20, 2025

@kibertoad Actually not.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants