Skip to content

Conversation

@torresga
Copy link
Contributor

@torresga torresga commented Oct 21, 2024

Jira Ticket

https://ombulabs.atlassian.net/browse/DT-459

Motivation / Context

My last PR failed due to actions/upload-artifact: v2 being deprecated:
https://github.com/fastruby/points/actions/runs/11441953756/job/31831210476?pr=331

I am updating upload-artifact: v2 to see if this fixes the failure in the test suite. I am updating to version 4 specifically since version 3 will be deprecated by the end of November: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/.

Note: I know that the build-next-rails job still fails, as that job is running Rails 8.1.alpha.


I will abide by the code of conduct.

@torresga torresga changed the title Updates upload-artifact [Draft] DT-459: Updates upload-artifact [Draft] Oct 21, 2024
@torresga torresga marked this pull request as ready for review October 21, 2024 18:01
@torresga torresga changed the title DT-459: Updates upload-artifact [Draft] DT-459: Updates upload-artifact Oct 21, 2024
Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@JuanVqz JuanVqz merged commit 90efa4d into main Oct 23, 2024
1 of 2 checks passed
@JuanVqz JuanVqz deleted the fix/updates-upload-artifacts-in-build-rails-current branch October 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants