Add take_events() function (hacktoberfest-accepted)#392
Merged
wbarnha merged 3 commits intofaust-streaming:masterfrom Oct 24, 2022
Merged
Add take_events() function (hacktoberfest-accepted)#392wbarnha merged 3 commits intofaust-streaming:masterfrom
wbarnha merged 3 commits intofaust-streaming:masterfrom
Conversation
nguyentritai2906
force-pushed
the
master
branch
from
f775130 to
1bd0598
Compare
Member
|
Nice catch, this should hopefully close a lot of ongoing bugs. |
Member
|
Looks like the code needs to be linted. |
wbarnha
approved these changes
Oct 24, 2022
Member
wbarnha
left a comment
wbarnha
left a comment
There was a problem hiding this comment.
Doesn't break any features and adds functionality, so I consider this a definite approve. LGTM.
Codecov ReportBase: 94.45% // Head: 94.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
==========================================
- Coverage 94.45% 94.03% -0.42%
==========================================
Files 102 102
Lines 11023 11073 +50
Branches 1293 1297 +4
==========================================
+ Hits 10412 10413 +1
- Misses 533 582 +49
Partials 78 78
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wbarnha
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is from robinhood/faust adds a new function stream.take_events() which will return events()