Add KeyEventResult enum and support passthrough (filter) mode#30
Open
buzztaiki wants to merge 2 commits intofcitx:masterfrom
Open
Add KeyEventResult enum and support passthrough (filter) mode#30buzztaiki wants to merge 2 commits intofcitx:masterfrom
buzztaiki wants to merge 2 commits intofcitx:masterfrom
Conversation
Closed
Member
|
can you add a test? |
Author
|
sure, I try to add a test. |
40848a5 to
0c30244
Compare
Author
|
@wengxt I've added tests for KeyEvent result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a passthrough mode to the KeyEvent handler by extending its return value handling.
I also introduced the KeyEventResult enum to provide a way to choose between NotHandled, Handled, and Passthrough from Lua. This solves the issue where users need to bypass Fcitx5 for specific applications (like Emacs with DDSKK) in Wayland environments.
Example usage