Skip to content

Support inherited static functions #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Support inherited static functions #679

Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
df14445
ci: Add ability to find documentation for static functions defined in…
letynsoft Oct 28, 2018
c6eda5f
fix: Fix some possible notices
letynsoft Oct 28, 2018
6fa6fd5
fix: Fix spacing
letynsoft Oct 28, 2018
d231f42
Fix: Small fixes
letynsoft Oct 28, 2018
107c962
test: The inherited static methods and properties
letynsoft Dec 22, 2018
89886b1
fix: We effectively don't need these tests
letynsoft Dec 22, 2018
637f2bc
fix: We don't need these
letynsoft Dec 22, 2018
cc4a63f
fix: Move the leftovet bit outside
letynsoft Dec 22, 2018
296d105
Merge remote-tracking branch 'upstream/master'
letynsoft Dec 22, 2018
c484e65
Merge remote-tracking branch 'origin/master' into staticMethodsInParents
letynsoft Dec 22, 2018
c3b8cbd
fix: Yet another copy of unused reference
letynsoft Dec 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions src/DefinitionResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,21 +493,37 @@ private function resolveScopedPropertyAccessExpressionNodeToFqn(Node\Expression\
} elseif ($scoped->scopeResolutionQualifier instanceof Node\QualifiedName) {
$className = $scoped->scopeResolutionQualifier->getResolvedName();
}
if ($scoped->memberName instanceof Node\Expression\Variable) {
$origName = null;
do {
if ($scoped->memberName instanceof Node\Expression\Variable) {
if ($scoped->parent instanceof Node\Expression\CallExpression) {
return null;
}
$memberName = $scoped->memberName->getName();
if (empty($memberName)) {
return null;
}
$name = (string)$className . '::$' . $memberName;
} else {
$name = (string)$className . '::' . $scoped->memberName->getText($scoped->getFileContents());
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of logic here that does not change on each loop iteration, such as the instanceof checks above and the member name. Could you save this in variables and move it out of the loop?

if ($scoped->parent instanceof Node\Expression\CallExpression) {
return null;
$name .= '()';
}
$memberName = $scoped->memberName->getName();
if (empty($memberName)) {
return null;
if ($origName === null) {
$origName = $name;
}
$name = (string)$className . '::$' . $memberName;
} else {
$name = (string)$className . '::' . $scoped->memberName->getText($scoped->getFileContents());
}
if ($scoped->parent instanceof Node\Expression\CallExpression) {
$name .= '()';
}
$definition = $this->index->getDefinition($name);
if (!!$definition) {
break;
} else {
$class = $this->index->getDefinition((string)$className);
if ($class === null || empty($class->extends)) {
return $origName;
}
$className = $class->extends[0];
}
} while (true);
return $name;
}

Expand Down