Merged
Conversation
- Add 'ra_format' configuration option to plotting settings (default: 'hour') - Support 'deg' format to display RA in decimal degrees instead of hours - Apply to all map plots: psmap, tsmap, residmap, localization, extension - Add ra_format option to psmap configuration for method-specific control - Include documentation with usage examples - Addresses issue #622 and related PR request Co-authored-by: ndilalla <ndilalla@stanford.edu>
Co-authored-by: ndilalla <ndilalla@stanford.edu>
Co-authored-by: ndilalla <ndilalla@stanford.edu>
Co-authored-by: ndilalla <ndilalla@stanford.edu>
|
Cursor Agent can help with this pull request. Just |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 50.96% 51.06% +0.10%
==========================================
Files 144 144
Lines 27359 27428 +69
==========================================
+ Hits 13943 14006 +63
- Misses 13416 13422 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add ra_format configuration to residmap, tsmap, tscube, localize, and extension - Update all plotting methods to propagate ra_format parameter: - make_roi_plots: Pass ra_format through roi_kwargs - make_localization_plots: Support ra_format in both plot instances - make_extension_plots: Support ra_format in _plot_extension_tsmap - Update analysis methods to pass ra_format from config: - tsmap: Pass ra_format to make_tsmap_plots - tscube: Pass ra_format to make_tsmap_plots - residmap: Pass ra_format to make_residmap_plots - localize: Pass ra_format to make_localization_plots - extension: Pass ra_format to make_extension_plots - Ensure complete coverage for all map generation methods in fermipy - write_roi already supports ra_format via make_plots -> plotter.run Co-authored-by: ndilalla <ndilalla@stanford.edu>
- Document support for all map types (psmap, tsmap, tscube, residmap, localize, extension, ROI plots) - Add comprehensive examples for all methods - Update configuration examples with all supported methods - Clarify that ALL map generation methods support ra_format Co-authored-by: ndilalla <ndilalla@stanford.edu>
Co-authored-by: ndilalla <ndilalla@stanford.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ra_formatconfiguration to allow users to display Right Ascension in degrees instead of hours in map plots.This addresses a user request (issue #622) to provide flexibility in RA axis labeling for sky maps. The default behavior remains RA in hours, ensuring backward compatibility.